Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Mapping in immutabledict constructor #51

Merged
merged 2 commits into from
Jun 10, 2019

Conversation

berquist
Copy link
Member

@berquist berquist commented Jun 7, 2019

Closes #50

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files           6        6           
  Lines         617      617           
=======================================
  Hits          559      559           
  Misses         58       58
Impacted Files Coverage Δ
immutablecollections/_immutabledict.py 87.03% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6985a25...d341b69. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files           6        6           
  Lines         617      617           
=======================================
  Hits          559      559           
  Misses         58       58
Impacted Files Coverage Δ
immutablecollections/_immutabledict.py 87.03% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6985a25...8d72474. Read the comment docs.

Copy link
Contributor

@ConstantineLignos ConstantineLignos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small request, but don't bother acting on it until you have @rgabbard 's review.

immutablecollections/_immutabledict.py Outdated Show resolved Hide resolved
@berquist berquist merged commit e1daaa9 into master Jun 10, 2019
@ConstantineLignos ConstantineLignos deleted the 50-allow-mapping-for-immutabledict branch June 10, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update allowed input types for ImmutableDict creation
3 participants