Skip to content

Commit

Permalink
remote: deprecated --remote_local_fallback_strategy
Browse files Browse the repository at this point in the history
The flag is no-op because the flag --strategy can now accept a list of strategies, therefore a fallback specific for particular strategy is not possible. See bazelbuild#7480 for details.

RELNOTES: deprecated --remote_local_fallback_strategy. Use `--strategy=remote,local` instead. See bazelbuild#7480.
  • Loading branch information
ishikhman committed May 16, 2019
1 parent 5b17d5f commit 2516587
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,13 @@ public final class RemoteOptions extends OptionsBase {
"Whether to fall back to standalone local execution strategy if remote execution fails.")
public boolean remoteLocalFallback;

@Deprecated
@Option(
name = "remote_local_fallback_strategy",
defaultValue = "local",
documentationCategory = OptionDocumentationCategory.REMOTE,
effectTags = {OptionEffectTag.UNKNOWN},
help = "The strategy to use when remote execution has to fallback to local execution.")
help = "No-op, deprecated. See https://github.com/bazelbuild/bazel/issues/7480 for details.")
public String remoteLocalFallbackStrategy;

@Option(
Expand Down
4 changes: 2 additions & 2 deletions src/test/py/bazel/windows_remote_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ def _RunRemoteBazel(self, args, env_remove=None, env_add=None):
'--strategy=Closure=remote',
'--genrule_strategy=remote',
'--define=EXECUTOR=remote',
'--remote_executor=localhost:' + str(self._worker_port),
'--remote_cache=localhost:' + str(self._worker_port),
'--remote_executor=grpc://localhost:' + str(self._worker_port),
'--remote_cache=grpc://localhost:' + str(self._worker_port),
'--remote_timeout=3600',
'--auth_enabled=false',
'--remote_accept_cached=false',
Expand Down

0 comments on commit 2516587

Please sign in to comment.