Code

Add gaps with forced ventilation#2

Code

Closed

simon-wacker wants to merge 93 commits intomainise-bipv/Windows-CalcEngine:mainfrom add-gaps-with-forced-ventilationise-bipv/Windows-CalcEngine:add-gaps-with-forced-ventilationCopy head branch name to clipboard

+3,350-299

Commits

Commits on Dec 15, 2022

• Add gaps with forced ventilation

  simon-wacker

  committed
  e239f3d

  Copy full SHA for e239f3d

• Use existing ForcedVentilation member of CGasLayer declared in LayerInterfaces

  simon-wacker

  committed
  598eff9

  Copy full SHA for 598eff9

• Set speed and direction for forced ventilation and calculate temperatures as for natural ventilation

  simon-wacker

  committed
  810c099

  Copy full SHA for 810c099

• Assert that neither gap layer around a shade has forced ventilation

  simon-wacker

  committed
  c555e0c

  Copy full SHA for c555e0c

• Test temperatures of solid and shade layers surrounding the forced ventilated gap layer

  simon-wacker

  committed
  1b927a7

  Copy full SHA for 1b927a7

• Test forced ventilation with non-zero solar radiation

  simon-wacker

  committed
  6da5e77

  Copy full SHA for 6da5e77

• Add forced ventilation with zero air speed

  simon-wacker

  committed
  3c6c5c9

  Copy full SHA for 3c6c5c9

• Call solve on the Tarcog system after setting it up, change expected values accordingly, and test also test radiosities

  simon-wacker

  committed
  3f90046

  Copy full SHA for 3f90046

• Test the indoor heat flow for a system with a forced radiation gap positive solar radiation

  simon-wacker

  committed
  6bbf506

  Copy full SHA for 6bbf506

• Test natural ventilation of gap at edge

  simon-wacker

  committed
  ff59ee9

  Copy full SHA for ff59ee9

• Test natural ventilation of narrow gap at edge

  simon-wacker

  committed
  5a17a51

  Copy full SHA for 5a17a51

• Call solve on the Tarcog system after setting it up to calculate layer values like their temperatures, remove air-flow direction from forced ventilation as it does not matter, use the environment…

  Show description for 9e6c5ce
  simon-wacker

  committed
  9e6c5ce

  Copy full SHA for 9e6c5ce

• Support and calculate temperatures of sealed forced-ventilation gaps, that is, forced-ventilation gaps sandwiched between solids

  simon-wacker

  committed
  d30774d

  Copy full SHA for d30774d

• Make scoped traces in tests more expressive

  simon-wacker

  committed
  a07f922

  Copy full SHA for a07f922

• Test sealed and narrow forced-ventilation gap layer with zero air speed

  simon-wacker

  committed
  f1976a8

  Copy full SHA for f1976a8

• Turn to-do into note and remove legacy questions

  simon-wacker

  committed
  288742a

  Copy full SHA for 288742a

• Use closed shades to model sealed forced-ventilation gaps

  simon-wacker

  committed
  063bfba

  Copy full SHA for 063bfba

• Make transmittance and emissivity explicit and tell that reflectance is equal to 1 - emissivity - transmittance (the implicit defaults are defined in Layers.hpp#solid and Layers.hpp#shading`, a…

  Show description for b0a2f92
  simon-wacker

  committed
  b0a2f92

  Copy full SHA for b0a2f92

• Put declarations of air-direction enumerations back to where they used to be (to have an uncluttered difference view)

  simon-wacker

  committed
  1869b91

  Copy full SHA for 1869b91

• Add test for sealed gap at edge with natural ventilation

  simon-wacker

  committed
  632ea77

  Copy full SHA for 632ea77

• Add getters for m_HInput, m_HCoefficientModel, m_IRCalculatedOutside to environment and to system and test those values in winter and summer tests of forced-ventilation gaps with solar radiation

  simon-wacker

  committed
  df462b6

  Copy full SHA for df462b6

• Delete ventilation tests with narrow gaps

  simon-wacker

  committed
  352f72b

  Copy full SHA for 352f72b

• Improve naming of ventilated gap tests

  simon-wacker

  committed
  b06e310

  Copy full SHA for b06e310

• Add missing abbreviation IR for infrared to front and back transmittance argument names

  simon-wacker

  committed
  f500c6c

  Copy full SHA for f500c6c

• Name closedShading but sealedLayer

  simon-wacker

  committed
  1622b87

  Copy full SHA for 1622b87

• ForcedVentilation structure removed since it contained only one member double

  vidanovic

  committed
  d939296

  Copy full SHA for d939296

• Separation for setting of geometry vs setting direction.

  vidanovic

  committed
  bfad3a2

  Copy full SHA for bfad3a2

• Flow geometry is set only once

  vidanovic

  committed
  69bb2d8

  Copy full SHA for 69bb2d8

• Inlet temperature now have to be set in the separate routine and can be updated within the iterations or just left constant.

  vidanovic

  committed
  16402ef

  Copy full SHA for 16402ef

• Outlet temperature for the airflow calculations is moved into ventilated gap class

  vidanovic

  committed
  cebccb8

  Copy full SHA for cebccb8

• Setting flow temperatures is moved into ventilated gap class.

  vidanovic

  committed
  23de2ec

  Copy full SHA for 23de2ec

• Thermally driven speed of two connected gaps is moved into ventilated gap class.

  vidanovic

  committed
  dd99fa6

  Copy full SHA for dd99fa6

• In between shade ventilated gap calculations are moved into ventilated gap class

  vidanovic

  committed
  92638c5

  Copy full SHA for 92638c5

• Initialization of forced ventilation air speed moved from calcEdgeShadeFlow (Shading layer class) into ventilated gaps class.

  vidanovic

  committed
  8fdd67b

  Copy full SHA for 8fdd67b

• Airflow reference point calculations are now private functions. This also required to remove some of the unit tests for these private functions.

  vidanovic

  committed
  4ceef2d

  Copy full SHA for 4ceef2d

Commits on Dec 16, 2022

• Moving more functions into private

  vidanovic

  committed
  e3ba862

  Copy full SHA for e3ba862

• Calculation of airflow for the edge case is now completely moved out of shading layer class

  vidanovic

  committed
  97c9f8b

  Copy full SHA for 97c9f8b

• Thermally driven ventilation between two gaps is moved into Ventilated Gap class

  vidanovic

  committed
  d3ec632

  Copy full SHA for d3ec632

• Couple of more functions from ventilated gap moved into the private section.

  vidanovic

  committed
  39c8afc

  Copy full SHA for 39c8afc

• Top and Bottom opening multipliers are no longer saved with the ventilation gap class but rather impendances are calculated only once and stored premanently. This will also speed up ventilation cal…

  Show description for e96c26e
  vidanovic

  committed
  e96c26e

  Copy full SHA for e96c26e

• Fixed the issue in thermally driven airflow calculations where the inlet temperature was not updating correctly.

  vidanovic

  committed
  4ae8033

  Copy full SHA for 4ae8033

Commits on Dec 17, 2022

• Inlet and outlet temperatures are stored in a single structure.

  vidanovic

  committed
  b46f1fb

  Copy full SHA for b46f1fb

• Forced airflow calculations are now called for non-shading layers in the system. Unit test for forced ventilation are not passing and results needs to be verfied now with the new approach.

  vidanovic

  committed
  3ab5111

  Copy full SHA for 3ab5111

Commits on Dec 19, 2022

• Update to unit test that perform forced ventilation of the gap at the edge (with outside and inside inlet airflow).

  vidanovic

  committed
  f90cf95

  Copy full SHA for f90cf95

• Forced ventilation on the edge cases with the different values of the solar radiation.

  vidanovic

  committed
  37a42b1

  Copy full SHA for 37a42b1

• Update to all unit test performed. Still missing test for in between forced ventilation.

  vidanovic

  committed
  3981716

  Copy full SHA for 3981716

• Forced ventilation for in between case is now in tests as well.

  vidanovic

  committed
  3566251

  Copy full SHA for 3566251

Commits on Jan 3, 2023

• Merge pull request #4 from ise-bipv/airflow-refactoring

  Show description for a079bec
  simon-wacker

  authored
  a079bec

  Copy full SHA for a079bec

Commits on Jan 5, 2023

• Copy example GapLayerAtEdgeForcedVentilationInsideAir.unit.cpp and rename it as the first step to create a new example

  christoph-maurer

  committed
  90c7688

  Copy full SHA for 90c7688

Commits on Jan 18, 2023

• Rename the class TestGapLayerAtEdgeForcedVentilationOutsideAir to TestGapBetweenExteriorShadingAndGlassForcedVentilationOutsideAir. Test successfully.

  christoph-maurer

  committed
  840aae7

  Copy full SHA for 840aae7

• The results of the new test indicate that the shading has zero absorptance.

  christoph-maurer

  committed
  6c5799f

  Copy full SHA for 6c5799f

• Fail to add absorptance as in DoubleOutsidePerforatedShade_SHGC.unit.cpp . Error message: `[----------] 5 tests from TestGapBetweenIrradiatedExteriorShadingAndGlassForcedVentilationOutsideAir

  Show description for c748a12
  christoph-maurer

  committed
  c748a12

  Copy full SHA for c748a12

Commits on Jan 19, 2023

• Do not upgrade gap layers that already are ventilated

  simon-wacker

  committed
  6dd4746

  Copy full SHA for 6dd4746

• Remove unused includes

  simon-wacker

  committed
  7ba05b8

  Copy full SHA for 7ba05b8

• Use CSingleSystem as m_TarcogSystem

  simon-wacker

  committed
  885d09b

  Copy full SHA for 885d09b

• Declare missing air temperature variable

  simon-wacker

  committed
  1f1f6c1

  Copy full SHA for 1f1f6c1

• Assert non-nullness of shade layer

  simon-wacker

  committed
  1687b3a

  Copy full SHA for 1687b3a

• Solve the system at end of test set-up

  simon-wacker

  committed
  a77ff0b

  Copy full SHA for a77ff0b

• Give variables more readable and expressive names

  simon-wacker

  committed
  e915396

  Copy full SHA for e915396

• Correct expected numbers

  simon-wacker

  committed
  cf4de18

  Copy full SHA for cf4de18

• Correct expected ventilated flow in DoubleClarIndoorShadeAir tests

  simon-wacker

  committed
  ec900e5

  Copy full SHA for ec900e5

Commits on Jan 23, 2023

• Merge pull request #6 from ise-bipv/fix-outside-air-test

  Show description for 3c66501
  christoph-maurer

  authored
  3c66501

  Copy full SHA for 3c66501

Commits on Jan 24, 2023

• Create three test cases for validation with the software Winther

  christoph-maurer

  committed
  0186920

  Copy full SHA for 0186920

Commits on Jan 25, 2023

• Create tests for interior screen with varying height and mass flow of the forced convection.

  christoph-maurer

  committed
  0acb5e3

  Copy full SHA for 0acb5e3

• Rename the validation tests to make them more consistend with the other GapBetween* tests.

  christoph-maurer

  committed
  c750c4e

  Copy full SHA for c750c4e

Commits on Jan 26, 2023

• Finish renaming the 8 tests for validation and explanation

  christoph-maurer

  committed
  8685f9d

  Copy full SHA for 8685f9d

• Use new lines consistently in the blocks of the 8 new tests

  christoph-maurer

  committed
  cdfaf88

  Copy full SHA for cdfaf88

• Add test with exterior shading and forced convection with roomTemperature for comparison.

  christoph-maurer

  committed
  d0e7cc8

  Copy full SHA for d0e7cc8

• Add tests to compare zero forced convection with the natural convection of a gap without forced convection. Why is there a difference? Relates to #5

  christoph-maurer

  committed
  03a1d55

  Copy full SHA for 03a1d55

• Start test with 2 glass panes and 1 shading in between, but the test do not run properly.

  christoph-maurer

  committed
  b78d795

  Copy full SHA for b78d795

Commits on Jan 31, 2023

• Fix test GapBetweenIrradiatedGlassPanesWithIntegratedShadingForcedVentilation by adding m_TarcogSystem->solve();

  christoph-maurer

  committed
  1d5827e

  Copy full SHA for 1d5827e

Commits on Feb 1, 2023

• Add getters for inlet and outlet temperatures

  simon-wacker

  committed
  180b857

  Copy full SHA for 180b857

Commits on Feb 2, 2023

• Merge pull request #7 from ise-bipv/add-getters-for-inlet-and-oulet-temperature

  Show description for e59d39a
  christoph-maurer

  authored
  e59d39a

  Copy full SHA for e59d39a

Commits on Feb 3, 2023

• Add example with very thick glass to calculate the external and internal heat transfer coefficients

  christoph-maurer

  committed
  723c4ed

  Copy full SHA for 723c4ed

Commits on Mar 14, 2023

• Fail to print the indoor radiative heat transfer coefficient

  Show description for 0a0fef4
  christoph-maurer

  committed
  0a0fef4

  Copy full SHA for 0a0fef4

• No error message anymore, but no results neither.

  christoph-maurer

  committed
  49a8407

  Copy full SHA for 49a8407

Commits on Mar 15, 2023

• The heat transfer coefficients of the summer validation look fine

  christoph-maurer

  committed
  c9a2ea4

  Copy full SHA for c9a2ea4

• Test the heat transfer coefficients of all three validation cases

  christoph-maurer

  committed
  83c4540

  Copy full SHA for 83c4540

• Merge pull request #8 from ise-bipv/print-heat-transfer-coefficients

  Show description for 1131b07
  christoph-maurer

  authored
  1131b07

  Copy full SHA for 1131b07

• Describe when the is used

  christoph-maurer

  committed
  4f96c01

  Copy full SHA for 4f96c01

Commits on Mar 21, 2023

• Add old test from Windows-CalcEngine

  christoph-maurer

  committed
  43c36f4

  Copy full SHA for 43c36f4

• Remove the tests which are replaced by the tests GapBetween*

  christoph-maurer

  committed
  af0f0be

  Copy full SHA for af0f0be

• Correct expected values

  simon-wacker

  committed
  1167e31

  Copy full SHA for 1167e31

• Add test with naturally ventilated and sealed gap to cross validate the forced ventilation test TestGapBetweenIrradiatedGlassAndInteriorShadingZeroForcedVentilation

  simon-wacker

  committed
  25815c7

  Copy full SHA for 25815c7

• Merge pull request #5 from ise-bipv/more-examples-of-gaps-with-forced-ventilation

  Show description for d3016c0
  simon-wacker

  authored
  d3016c0

  Copy full SHA for d3016c0

Commits on Mar 23, 2023

• Revert commit 3492a6d the getters introduced there are not used anywhere and at least getIRCalculatedOutside is actually not needed due to 3492a6d#commitcomment-105581336

  simon-wacker

  committed
  c68a90c

  Copy full SHA for c68a90c

Commits on Apr 12, 2023

• Compare with 1mm gap zeroForced and natural convection

  christoph-maurer

  committed
  d56a8c0

  Copy full SHA for d56a8c0

Commits on Apr 13, 2023

• Update name of the tests

  christoph-maurer

  committed
  c0f0b08

  Copy full SHA for c0f0b08

• The IRFlow differs between the 1mmGap tests

  christoph-maurer

  committed
  5012ebd

  Copy full SHA for 5012ebd

• The temperatures match with about +/- 0.02 K

  christoph-maurer

  committed
  327f77e

  Copy full SHA for 327f77e

• The IRFlow matches with +/- 0.02 W/m². The energy gain of ZeroForcedConvection is 0. The energy gain of NaturalConvection is 0.0439 W/m². Both is plausible.

  christoph-maurer

  committed
  f25af9b

  Copy full SHA for f25af9b

• Correct expected values

  simon-wacker

  committed
  19977cc

  Copy full SHA for 19977cc

• Merge pull request #9 from ise-bipv/compare-1mm-gap

  Show description for a29f592
  simon-wacker

  authored
  a29f592

  Copy full SHA for a29f592