Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#577 glossary contains references #669

Merged
merged 4 commits into from
Nov 10, 2024
Merged

#577 glossary contains references #669

merged 4 commits into from
Nov 10, 2024

Conversation

gernotstarke
Copy link
Member

@gernotstarke gernotstarke commented Oct 30, 2024 •
edited
Loading

@ulibecker or @skogsbaer could you please have a look... thx

@gernotstarke gernotstarke added V2025 Release 2025 documentation Documentation of any kind, e.g. for style, process, members etc labels Oct 30, 2024
@gernotstarke gernotstarke self-assigned this Oct 30, 2024
@gernotstarke gernotstarke mentioned this pull request Oct 30, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

Build Successful! You can find a link to the downloadable artifacts below.

Name Link
Commit d15830c
Logs https://github.com/isaqb-org/curriculum-foundation/actions/runs/11601670154
Download https://github.com/isaqb-org/curriculum-foundation/suites/30308337240/artifacts/2125436715

@skogsbaer
Copy link
Collaborator

looks good!

@alxlo
Copy link
Contributor

alxlo commented Nov 10, 2024

ping @skogsbaer - From what I can see, this ADR proposal can be traced back to your comment from #577.
I would really like to merge it to keep our backlog of PRs small. Technically merging is already possible but having feedback from you would be good.

skogsbaer
skogsbaer approved these changes Nov 10, 2024
View reviewed changes
Copy link
Collaborator

@skogsbaer skogsbaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@skogsbaer
Copy link
Collaborator

ping @skogsbaer - From what I can see, this ADR proposal can be traced back to your comment from #577. I would really like to merge it to keep our backlog of PRs small. Technically merging is already possible but having feedback from you would be good.

I already added a positiv comment last week. I've now added my review and merged to PR.

@skogsbaer skogsbaer merged commit cfb0015 into main Nov 10, 2024
1 check passed
@skogsbaer skogsbaer deleted the #577-glossary-contains-references branch November 10, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulibecker ulibecker ulibecker approved these changes

@alxlo alxlo alxlo approved these changes

@skogsbaer skogsbaer skogsbaer approved these changes

Assignees

@gernotstarke gernotstarke

Labels
documentation Documentation of any kind, e.g. for style, process, members etc V2025 Release 2025
Projects
V-2025
Status: Done / Implemented
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gernotstarke @skogsbaer @alxlo @ulibecker