Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sesar things script #3

Merged
merged 6 commits into from
Nov 1, 2023
Merged

add sesar things script #3

merged 6 commits into from
Nov 1, 2023

Conversation

SeanSCao
Copy link
Collaborator

@SeanSCao SeanSCao commented Oct 26, 2023

Example thing rows:
image

@SeanSCao SeanSCao changed the title create seperate sesar sqlmodel registry add sesar things script Oct 31, 2023
Copy link
Member

@dannymandel dannymandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all, this looks really great! Nice work @SeanSCao! The only suggestion I have offhand is that I think you want to include the IGSN: prefix in the identifier for the things. That's the way it is done now, and will be helpful to keep doing so, as we also deal with ark: prefixes, and it's good to keep the two separate.

@datadavev
Copy link
Member

All in all, this looks really great! Nice work @SeanSCao! The only suggestion I have offhand is that I think you want to include the IGSN: prefix in the identifier for the things. That's the way it is done now, and will be helpful to keep doing so, as we also deal with ark: prefixes, and it's good to keep the two separate.

Yes, all identifiers should be absolute, which means the scheme part must be present. The scheme is generally lower case, technically it is case insensitive, but within a system should be consistent. DataCite indicates the proper form for an IGSN identifier is to use lower case igsn: for the scheme and we should follow that practice.

@SeanSCao SeanSCao merged commit a4345b1 into main Nov 1, 2023
1 check passed
@SeanSCao SeanSCao deleted the sesar_thing branch November 1, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants