unpack: accept fflag as an option #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2019
Merged
isaacs
reviewed
Sep 17, 2019
| const path = require('path') | ||
| const file = process.argv[2] || path.resolve(__dirname, '../npm.tar') | ||
| const fs = require('fs') | ||
| const { O_CREAT, O_TRUNC, O_WRONLY, UV_FS_O_FILEMAP } = fs.constants |
There was a problem hiding this comment.
Minor nit: this should provide a default value of 0. undefined will boolean-or to 0 anyway, but save the JS interpreter having to change the types around.
|
@isaacs updated, thanks for reviewing! UV_FS_O_FILEMAP should not be enabled by default in tar, because it is slower for large files (>1MB). It should however be enabled by default in npm where most files are small: npm/pacote#8 |
The file size is known in advance when extracting a tar entry, so it seems like we should default it for cases where we know it's going to be a benefit, no? |
|
Closing in favor of #230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the WriteStream flags to be used when writing files to be specified as an option.
This allows programs using node-tar to take advantage of writing files using a file mapping, which can be significantly faster on Windows. Support landed in libuv in libuv/libuv#2295 and in Node.js in nodejs/node#29260.
For the included benchmarks, execution time drops from 6.6s to 2.8s for async and from 15.8s to 3.4s for sync on my local machine. This depends heavily on the machine being used: can range from negligible improvements to even better than the above.