Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stat): support throwIfNoEntry for statSync #220

Closed
wants to merge 1 commit into from

Conversation

bluelovers
Copy link
Contributor

No description provided.

@songhobby
Copy link

Can someone merge this? This bug breaks lots of things depending on it

@peteromano
Copy link

@bluelovers Nuxt3 development and the whole internet and world is broken until this is merged.

See: nuxt/nuxt#13155

Priority level 5000.

image

@songhobby
Copy link

songhobby commented Jan 4, 2022

@bluelovers Nuxt3 development and the whole internet and world is broken until this is merged.

I come from Next.js world, same thing and very accurately said, the world is broken until this is MERGED!

@isaacs isaacs closed this in e61a20a Jan 5, 2022
@isaacs
Copy link
Owner

isaacs commented Jan 5, 2022

Landed and published. You can all stop posting memes and blowing up my notifications on social media now.

Listen. I'm sensitive to the frustration that you feel when something breaks because of a change that some part of the system didn't know to accommodate. Especially when it's not something you can fix easily.

That said, if a piece of code just sitting there not changing can break the whole internet, then I don't know, maybe it should be broken. Did you consider that this is a bug in the thing that calls statSync({ throwIfNoEntry: false })? That perhaps it shouldn't be used with graceful-fs? Or maybe that the thing using graceful-fs shouldn't be using it in the way it does? Or as your app grows into a rube goldberg machine (as every piece of software eventually does), maybe it just doesn't work when you bump to Node.js version higher than 14.17 or using it with whatever updates to whatever things led to it calling statSync({throwIfNoEntry: false}) through graceful-fs.

Or you could have just, idk, forked this library and maintained it more regularly. I don't use it much anymore, and frankly, the safest thing to do is just not touch it.

Take a breath. Touch some grass. Be nice to people. It's going to be OK. This bug is not the thing breaking the world, I fucking promise you that.

Repository owner locked as resolved and limited conversation to collaborators Jan 5, 2022
eventualbuddha added a commit to votingworks/vxsuite that referenced this pull request Apr 20, 2022
Ensures that the version of `graceful-fs` in use includes this fix: isaacs/node-graceful-fs#220. This was breaking `jest-resolve` for reasons I don't fully understand, making it unable to load tests for `res-to-ts`.

I wasn't able to figure out how to make `pnpm` update `graceful-fs` to the version I wanted as a transitive dependency. I tried `pnpm update [email protected]` and similar, but none worked. Instead, I manually updated the lockfile to point to `graceful-fs: 4.2.10` and removed the `graceful-fs` entries, then ran `pnpm install` to make `pnpm` fix the broken lockfile.

Fixes #1716
eventualbuddha added a commit to votingworks/vxsuite that referenced this pull request Apr 20, 2022
Ensures that the version of `graceful-fs` in use includes this fix: isaacs/node-graceful-fs#220. This was breaking `jest-resolve` for reasons I don't fully understand, making it unable to load tests for `res-to-ts`.

I wasn't able to figure out how to make `pnpm` update `graceful-fs` to the version I wanted as a transitive dependency. I tried `pnpm update [email protected]` and similar, but none worked. Instead, I manually updated the lockfile to point to `graceful-fs: 4.2.10` and removed the `graceful-fs` entries, then ran `pnpm install` to make `pnpm` fix the broken lockfile.

Fixes #1716
eventualbuddha added a commit to votingworks/vxsuite that referenced this pull request Apr 20, 2022
Ensures that the version of `graceful-fs` in use includes this fix: isaacs/node-graceful-fs#220. This was breaking `jest-resolve` for reasons I don't fully understand, making it unable to load tests for `res-to-ts`.

I wasn't able to figure out how to make `pnpm` update `graceful-fs` to the version I wanted as a transitive dependency. I tried `pnpm update [email protected]` and similar, but none worked. Instead, I manually updated the lockfile to point to `graceful-fs: 4.2.10` and removed the `graceful-fs` entries, then ran `pnpm install` to make `pnpm` fix the broken lockfile.

Fixes #1716
eventualbuddha added a commit to votingworks/vxsuite that referenced this pull request Apr 21, 2022
Ensures that the version of `graceful-fs` in use includes this fix: isaacs/node-graceful-fs#220. This was breaking `jest-resolve` for reasons I don't fully understand, making it unable to load tests for `res-to-ts`.

I wasn't able to figure out how to make `pnpm` update `graceful-fs` to the version I wanted as a transitive dependency. I tried `pnpm update [email protected]` and similar, but none worked. Instead, I manually updated the lockfile to point to `graceful-fs: 4.2.10` and removed the `graceful-fs` entries, then ran `pnpm install` to make `pnpm` fix the broken lockfile.

Fixes #1716
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants