Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid hitting __proto__ #201

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion clone.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,16 @@

module.exports = clone

var getPrototypeOf = Object.getPrototypeOf || function (obj) {
return obj.__proto__
}

function clone (obj) {
if (obj === null || typeof obj !== 'object')
return obj

if (obj instanceof Object)
var copy = { __proto__: obj.__proto__ }
var copy = { __proto__: getPrototypeOf(obj) }
else
var copy = Object.create(null)

Expand Down
2 changes: 1 addition & 1 deletion polyfills.js
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ function patch (fs) {
}

// This ensures `util.promisify` works as it does for native `fs.read`.
read.__proto__ = fs$read
if (Object.setPrototypeOf) Object.setPrototypeOf(read, fs$read)
coreyfarrell marked this conversation as resolved.
Show resolved Hide resolved
return read
})(fs.read)

Expand Down