You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This module is awesome. I don't know why it's not just in core node.js all the time.
I often want to require it in my applications. However sometimes I don't want to require it, but I end up requiring it anyway, because 8 module dependencies down the chain, some module has depended on graceful-fs without understanding the consequences.
Can we put a notice in the README that says, "HEY MODULE AUTHORS do not depend on this. This is for applications to depend on only."
Closes#27
Due to the way that streams and the various FS methods interact with one
another, NOT monkey-patching doesn't work.
However, since the 'fs' module is effectively a process-level global,
making monkey-patchy changes to it can introduce some really weird behavior.
Even if such behavior is not actively harmful, it can end up being
applied multiple times, and wrapping 'fs.open()' over and over again
is a bit of a bummer when it comes to performance.
Mixing 'eval()' and a private/internal Node API kind of gives me the
heeby jeebies. If anyone can come up with a less evil way to do this,
I'll be happy to accept a patch.
This module is awesome. I don't know why it's not just in core node.js all the time.
I often want to require it in my applications. However sometimes I don't want to require it, but I end up requiring it anyway, because 8 module dependencies down the chain, some module has depended on graceful-fs without understanding the consequences.
Can we put a notice in the README that says, "HEY MODULE AUTHORS do not depend on this. This is for applications to depend on only."
For example: EvanOxfeld/node-unzip#54
The text was updated successfully, but these errors were encountered: