Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS X Mavericks, cannot find module graceful-fs #27

Closed
ashalaby opened this issue Apr 3, 2014 · 1 comment
Closed

OS X Mavericks, cannot find module graceful-fs #27

ashalaby opened this issue Apr 3, 2014 · 1 comment

Comments

@ashalaby
Copy link

ashalaby commented Apr 3, 2014

I tried removing and re-installing node many times to get graceful-fs module to work but no luck. The graceful-fs direcotry exists under:
usr/local/lib/node_modules/

Still when I run my NodeJS app, it cannot find the module.

Thank you!
@isaacs
Copy link
Owner

isaacs commented Apr 4, 2014

You need to install it locally (ie, in your app), not globally.

@isaacs isaacs closed this as completed Apr 4, 2014
isaacs added a commit that referenced this issue Jun 2, 2014
@isaacs
Eval is less evil than monkey-patching a global
08471b2 
Closes #27

Due to the way that streams and the various FS methods interact with one
another, NOT monkey-patching doesn't work.

However, since the 'fs' module is effectively a process-level global,
making monkey-patchy changes to it can introduce some really weird behavior.
Even if such behavior is not actively harmful, it can end up being
applied multiple times, and wrapping 'fs.open()' over and over again
is a bit of a bummer when it comes to performance.

Mixing 'eval()' and a private/internal Node API kind of gives me the
heeby jeebies.  If anyone can come up with a less evil way to do this,
I'll be happy to accept a patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isaacs @ashalaby