-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neutral JavaScript runtime support (Deno, Bun, etc) #580
Comments
This was referenced Mar 31, 2024
sgammon
added a commit
to sgammon/minipass
that referenced
this issue
Mar 31, 2024
This adjusts Node built-in imports to use the `node:` prefix, so that such imports work on all runtimes. Fixes and closes isaacs#54 Relates to isaacs/node-glob#580 and isaacs/path-scurry#16 Signed-off-by: Sam Gammon <[email protected]>
This was referenced Mar 31, 2024
sgammon
added a commit
to sgammon/path-scurry
that referenced
this issue
Mar 31, 2024
This changeset fixes and closes isaacs#16 so that this package can be used on all JS runtimes. Relates to isaacs/node-glob#580 Signed-off-by: Sam Gammon <[email protected]>
sgammon
added a commit
to sgammon/node-glob
that referenced
this issue
Mar 31, 2024
Fixes and closes isaacs#580 by switching to `node:`- prefixed requires for Node API builtins. Will need releases for `minipass` and `path-scurry`, PRs for these are noted below. Relates to: - isaacs/path-scurry#17 - isaacs/minipass#55 Signed-off-by: Sam Gammon <[email protected]>
sgammon
added a commit
to sgammon/hashlock
that referenced
this issue
Mar 31, 2024
- feat: support all popular js runtimes - patches for `glob`, `minipass`, and `path-scurry` - upstream prs (listed below) - test entrypoint commands - test: add test entrypoints for each major runtime - test: add scripts to test entrypoint with each major runtime - chore: sync lockfiles Related Issues - isaacs/node-glob#580 - isaacs/path-scurry#16 - isaacs/minipass#54 - tj/commander.js#2169 Upstream PRs - isaacs/node-glob#581 - isaacs/minipass#55 - isaacs/path-scurry#17 - tj/commander.js#2170 Signed-off-by: Sam Gammon <[email protected]>
sgammon
added a commit
to sgammon/hashlock
that referenced
this issue
Mar 31, 2024
- feat: support all popular js runtimes - patches for `glob`, `minipass`, and `path-scurry` - upstream prs (listed below) - test entrypoint commands - test: add test entrypoints for each major runtime - test: add scripts to test entrypoint with each major runtime - chore: sync lockfiles Related Issues - isaacs/node-glob#580 - isaacs/path-scurry#16 - isaacs/minipass#54 - tj/commander.js#2169 Upstream PRs - isaacs/node-glob#581 - isaacs/minipass#55 - isaacs/path-scurry#17 - tj/commander.js#2170 Signed-off-by: Sam Gammon <[email protected]>
sgammon
added a commit
to sgammon/hashlock
that referenced
this issue
Mar 31, 2024
- feat: support all popular js runtimes - patches for `glob`, `minipass`, and `path-scurry` - upstream prs (listed below) - test entrypoint commands - test: add test entrypoints for each major runtime - test: add scripts to test entrypoint with each major runtime - chore: sync lockfiles Related Issues - isaacs/node-glob#580 - isaacs/path-scurry#16 - isaacs/minipass#54 - tj/commander.js#2169 Upstream PRs - isaacs/node-glob#581 - isaacs/minipass#55 - isaacs/path-scurry#17 - tj/commander.js#2170 Signed-off-by: Sam Gammon <[email protected]>
sgammon
added a commit
to sgammon/hashlock
that referenced
this issue
Mar 31, 2024
* feat: support all runtimes - feat: support all popular js runtimes - patches for `glob`, `minipass`, and `path-scurry` - upstream prs (listed below) - test entrypoint commands - test: add test entrypoints for each major runtime - test: add scripts to test entrypoint with each major runtime - chore: sync lockfiles Related Issues - isaacs/node-glob#580 - isaacs/path-scurry#16 - isaacs/minipass#54 - tj/commander.js#2169 Upstream PRs - isaacs/node-glob#581 - isaacs/minipass#55 - isaacs/path-scurry#17 - tj/commander.js#2170 Signed-off-by: Sam Gammon <[email protected]> * chore: version bump → `1.0.3` Signed-off-by: Sam Gammon <[email protected]> --------- Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>
isaacs
pushed a commit
to isaacs/path-scurry
that referenced
this issue
May 9, 2024
This changeset fixes and closes #16 so that this package can be used on all JS runtimes. Relates to isaacs/node-glob#580 Signed-off-by: Sam Gammon <[email protected]> PR-URL: #17 Credit: @sgammon Close: #17 Reviewed-by: @isaacs
isaacs
pushed a commit
to isaacs/minipass
that referenced
this issue
May 9, 2024
This adjusts Node built-in imports to use the `node:` prefix, so that such imports work on all runtimes. Fixes and closes #54 Relates to isaacs/node-glob#580 and isaacs/path-scurry#16 Signed-off-by: Sam Gammon <[email protected]> PR-URL: #55 Credit: @sgammon Close: #55 Reviewed-by: @isaacs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello there, @isaacs!
I'm a big fan of
node-glob
, having used it in several projects now. It is super fast and generally just works great 😄 however, in a tool downstream,hashlock
, I am trying to make it runtime-neutral, so that consuming users can use it on whatever runtime they want (Deno, Bun, Node, are my targets).glob
already works fantastically well on Node and Bun, but Deno seems to hiccup, because it wantsnode:
-prefixed imports for builtins. Not shipping with these was quite sensible. Now that Node 16 is EOL, though, there really should be very few Node instances out in the wild that are running pre-16 versions, sonode:
-prefixed imports can be relied upon.Using these imports works universally across Node, Bun, and Deno, and so for a very small change
glob
can be used anywhere. See below for the diff that I generated withpatch-package
, and a PR is incoming shortly.Note
For
glob
to be fully compatible with Deno, changes are neededpath-scurry
andminipass
as well. Those PRs and issues will tag this one for easy reference.Related issues:
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered: