-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type and runtime checks for default
and validOptions
combos
#18
Merged
isaacs
merged 9 commits into
isaacs:main
from
lukekarrys:lk/validate-default-valid-options-2
Sep 23, 2024
Merged
Type and runtime checks for default
and validOptions
combos
#18
isaacs
merged 9 commits into
isaacs:main
from
lukekarrys:lk/validate-default-valid-options-2
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
changed the title
lk/validate default valid options 2
Valid options and defaults types/checks
Aug 16, 2024
TODO:
|
lukekarrys
force-pushed
the
lk/validate-default-valid-options-2
branch
from
August 16, 2024 22:26
d048f82
to
3f08164
Compare
This was referenced Aug 17, 2024
lukekarrys
changed the title
Valid options and defaults types/checks
Type and runtime checks for Aug 19, 2024
default
and validOptions
combos
lukekarrys
force-pushed
the
lk/validate-default-valid-options-2
branch
2 times, most recently
from
August 19, 2024 17:42
fad3f72
to
3f729ea
Compare
lukekarrys
force-pushed
the
lk/validate-default-valid-options-2
branch
from
August 19, 2024 17:51
3f729ea
to
6e96ca1
Compare
Also donsolidate if statement branches for field validation
lukekarrys
force-pushed
the
lk/validate-default-valid-options-2
branch
from
August 19, 2024 18:20
6e96ca1
to
c81ea16
Compare
Open
PR-URL: isaacs#18 Credit: @lukekarrys Close: isaacs#18 Reviewed-by: @isaacs
isaacs
force-pushed
the
lk/validate-default-valid-options-2
branch
from
September 23, 2024 18:53
c81ea16
to
3abd065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things in the name of increasing type and runtime checks for fields with the full combination of
default
andvalidOptions
across differenttype
andmultiple
combinations. Fixes #17Some other notable items:
index.ts
so all types are at the top withisType
functions below their type counterpartaddFields/opt/optList/num/numList/flag/flagList
so they all get the same behaviorSome possible breaking changes due to some of the above refactoring:
type MultiType
is gone since it was no longer needed in the same waytype ConfigOptionBase
is nowtype ConfigOption
. This is maybe a bit arbitrary but I think matches better to how it is used.