Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Create ISSUE_TEMPLATE.md #792

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jimmywarting
Copy link

@jimmywarting jimmywarting commented Oct 12, 2016

This was the result of a 578 comments long issue #253
skarmavbild 2016-10-12 kl 16 27 00

Some issues takes to long to load and sometimes fails. All the useless bumps of +1 adds no useful information to the issue and it becomes harder to summarize. This would probably also help others to avoid email spam

I could volunteer to help clean up some of the issues and even add this small footer to some of the issues already created but I'm not a collaborator...

Here is a preview of what it will look like when you create a new issue:


comments like +1 me too will be deleted
▼Vote with reaction▼

@TPS
Copy link
Collaborator

TPS commented Oct 24, 2016

Nowadays, long issues don't typically 🦄, but, like just below #18 (comment), 1658 items not shown
View more
shows up, instead. 🦄s are usually reserved for other @github backend issues.

Still, this'd be awesome 'til #640 is implemented! Whaddya think, @isaacs @cirosantilli?

@TPS
Copy link
Collaborator

TPS commented Jun 16, 2017

@aspiers If you have merge access, go for it!

@aspiers
Copy link
Collaborator

aspiers commented Jun 16, 2017

I don't unfortunately.

@TPS
Copy link
Collaborator

TPS commented Jun 18, 2017

Also @cirosantilli.… Anyone else who may have write access?

@cirosantilli
Copy link
Collaborator

Sorry but I don't think this is worth it, what we really need is: #601

I also did 001e354 for now.

I would also give some more people admin powers to at mention those people, explain it to them, and delete their comments, but I can't give those admin powers with my role.

@TPS
Copy link
Collaborator

TPS commented Jun 18, 2017

@cirosantilli Yours is a bit more subtle, but gets it done. & all this is a stop-gap until whenever any/all these linked issues are accomplished.

@jimmywarting Is 001e354 sufficient for you to close this PR?

@jimmywarting
Copy link
Author

jimmywarting commented Jun 19, 2017

Doesn't matter to me so much anymore.
I stop subscription when to many ppl was spamming, so I'm not active in this repo anymore.

I'm sorry to say this but I don't think 001e354 will be sufficient enough.
I have learned that ppl are to lazy to read. So I don't think they will read the contribution.md

They will search for something, get directly into the issue, read the first and last comments since it's so many. And without reading much else post a stupid +1

I think a footer (template) in all new issues must be added to inform newcomers not to post a +1

Maybe not exactly my words comments like +1 me too will be deleted since there is nobody that will delete them

@tziporaziegler
Copy link

I've created an issue discussing blacklisting reaction only comments: #967

@Cyberboss
Copy link

I think this has been sort of addressed now that GitHub loads issue comments on demand

@jimmywarting
Copy link
Author

It's not only about the unicorn... it's about being able to read the the thread and be able to summarize the content of the thread and also ignore useless email bumps/spam from ppl only positing a irritating +1 message. It brings no valuable context, only frustration...

@stevinus73

This comment has been minimized.

@AraHaan
Copy link

AraHaan commented Oct 28, 2018

Why not just convert any and all “+" and "-" to thumbs up and thumbs down reactions to the issue instead? There problem solved.

@jimmywarting
Copy link
Author

That's not possible. Everyone only have one vote

@aspiers
Copy link
Collaborator

aspiers commented Oct 28, 2018

@cirosantilli sorry but I'm with @jimmywarting on this one. He is absolutely right that people are lazy and don't read CONTRIBUTING.md.

Additionally, any other solutions such as sorting comments by upvotes, or automatically hiding comments (as done by @Mottie's awesome userscript, refined-github, and more recently by GitHub itself) are just putting bandaids on the problem. In particular, they fail to prevent anyone subscribed to the issue from being spammed with notifications every time someone adds a useless comment.

So I think it's better to treat the cause rather than the symptoms, and try to educate users as much as possible how to use the system in the right way. Setting up a PR template which discourages commenters from adding dumb "+1" comments would definitely help with that. Having said that, I think this PR as it currently stands could use a bit of refinement before merging.


----

<p align="center"><i>comments like +1 me too will be deleted</i><br><b>&#x25BC;Vote with reaction&#x25BC;</b></p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's right to promise that useless comments will be deleted, because that commits some unspecified group of people to the task of moderating all comments and deleting the useless ones, without first creating any kind of system to ensure that will happen.

Instead I think it should:

  1. tell users not to add those kinds of comments
  2. clearly explains to them what to do instead ("Vote with reaction" is a good start, but I think it would be helpful to make it more explicit, since many users will not know what a "reaction" is)
  3. link to a document which explains why they should follow this advice (perhaps Auto-magically & retroactively have posts that are only ±1, &c, converted to reactions & hidden/deleted #640 in the first instance, although I think it would be worth writing a better explanation)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not unless a github bot application is made to detect them on post and automatically delete said comments.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true that a bot could take care of the deletion (and I'd personally be fine with that), but that would still be trying to put a bandaid on the symptoms rather than treating the cause. Ideally we need both.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @isaacs would be interested in installing https://github.com/apps/reaction/ to implement the conversion to reactions while @github is (presumably) solving this for real?

@TPS
Copy link
Collaborator

TPS commented Feb 22, 2019

Since this PR doesn't have a clear consensus to implement, I'd like to propose closing this, & perhaps revisit whenever such agreement can be reached.… Thoughts?

@aspiers
Copy link
Collaborator

aspiers commented Feb 22, 2019

@TPS looks like we have permisssion to amend this PR (not sure if that is due to our new collaborator status) but I'm also OK with closing ... as long as this idea doesn't get forgotten about and an alternative proposal gets submitted fairly soon :-)

@jimmywarting
Copy link
Author

jimmywarting commented May 12, 2020

Just notice this:

Skärmavbild 2020-05-12 kl  17 01 08

Isn't that wonderful!? Thanks github!

Makes this PR a little bit unnecessary. Haven't been subscribed to this repo and heard anything that's going on in this repos b/c of all useless +1 bumps

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants