-
-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: ignore ENOENT errors during chown
Some files might be deleted during chownr. This commit ignore ENOENT errors to tolerate such cases to mimic 'chown -R'. Fixes npm/cli#496
- Loading branch information
1 parent
deaa058
commit 5bbda8c
Showing
3 changed files
with
323 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| if (!process.getuid || !process.getgid) { | ||
| throw new Error("Tests require getuid/getgid support") | ||
| } | ||
|
|
||
| var curUid = +process.getuid() | ||
| , curGid = +process.getgid() | ||
| , test = require("tap").test | ||
| , mkdirp = require("mkdirp") | ||
| , rimraf = require("rimraf") | ||
| , fs = require("fs") | ||
| , path = require("path") | ||
|
|
||
| // sniff the 'id' command for other groups that i can legally assign to | ||
| var exec = require("child_process").exec | ||
| , groups | ||
| , dirs = [] | ||
| , files = [] | ||
|
|
||
| // Monkey-patch fs.readdirSync to remove f1 before the callback happens | ||
| const readdirSync = fs.readdirSync | ||
|
|
||
| var chownr = require("../") | ||
|
|
||
| exec("id", function (code, output) { | ||
| if (code) throw new Error("failed to run 'id' command") | ||
| groups = output.trim().split("=")[3].split(",").map(function (s) { | ||
| return parseInt(s, 10) | ||
| }).filter(function (g) { | ||
| return g !== curGid | ||
| }) | ||
|
|
||
| // console.error([curUid, groups[0]], "uid, gid") | ||
|
|
||
| rimraf("/tmp/chownr", function (er) { | ||
| if (er) throw er | ||
| var cnt = 5 | ||
| for (var i = 0; i < 5; i ++) { | ||
| mkdirp(getDir(), then) | ||
| } | ||
| function then (er, made) { | ||
| if (er) throw er | ||
| var f1 = path.join(made, "f1"); | ||
| files.push(f1) | ||
| fs.writeFileSync(f1, "file-1"); | ||
| var f2 = path.join(made, "f2"); | ||
| files.push(f2) | ||
| fs.writeFileSync(f2, "file-2"); | ||
| if (-- cnt === 0) { | ||
| runTest() | ||
| } | ||
| } | ||
| }) | ||
| }) | ||
|
|
||
| function getDir () { | ||
| var dir = "/tmp/chownr" | ||
|
|
||
| dir += "/" + Math.floor(Math.random() * Math.pow(16,4)).toString(16) | ||
| dirs.push(dir) | ||
| dir += "/" + Math.floor(Math.random() * Math.pow(16,4)).toString(16) | ||
| dirs.push(dir) | ||
| dir += "/" + Math.floor(Math.random() * Math.pow(16,4)).toString(16) | ||
| dirs.push(dir) | ||
| return dir | ||
| } | ||
|
|
||
| function runTest () { | ||
| test("patch fs.readdirSync", function (t) { | ||
| // Monkey-patch fs.readdirSync to remove f1 before returns | ||
| // This simulates the case where some files are deleted when chownr.sync | ||
| // is in progress | ||
| fs.readdirSync = function () { | ||
| const args = [].slice.call(arguments) | ||
| const dir = args[0] | ||
| const children = readdirSync.apply(fs, args); | ||
| try { | ||
| fs.unlinkSync(path.join(dir, 'f1')) | ||
| } catch (er) { | ||
| if (er.code !== 'ENOENT') throw er | ||
| } | ||
| return children | ||
| } | ||
| t.end() | ||
| }) | ||
|
|
||
| test("should complete successfully", function (t) { | ||
| // console.error("calling chownr", curUid, groups[0], typeof curUid, typeof groups[0]) | ||
| chownr.sync("/tmp/chownr", curUid, groups[0]) | ||
| t.end() | ||
| }) | ||
|
|
||
| test("restore fs.readdirSync", function (t) { | ||
| // Restore fs.readdirSync | ||
| fs.readdirSync = readdirSync | ||
| t.end() | ||
| }) | ||
|
|
||
| dirs.forEach(function (dir) { | ||
| test("verify "+dir, function (t) { | ||
| fs.stat(dir, function (er, st) { | ||
| if (er) { | ||
| t.ifError(er) | ||
| return t.end() | ||
| } | ||
| t.equal(st.uid, curUid, "uid should be " + curUid) | ||
| t.equal(st.gid, groups[0], "gid should be "+groups[0]) | ||
| t.end() | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| files.forEach(function (f) { | ||
| test("verify "+f, function (t) { | ||
| fs.stat(f, function (er, st) { | ||
| if (er) { | ||
| if (er.code !== 'ENOENT') | ||
| t.ifError(er) | ||
| return t.end() | ||
| } | ||
| t.equal(st.uid, curUid, "uid should be " + curUid) | ||
| t.equal(st.gid, groups[0], "gid should be "+groups[0]) | ||
| t.end() | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| test("cleanup", function (t) { | ||
| rimraf("/tmp/chownr/", function (er) { | ||
| t.ifError(er) | ||
| t.end() | ||
| }) | ||
| }) | ||
| } | ||
|
|
Oops, something went wrong.