Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade app dependencies #1256

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Conversation

jacbn
Copy link
Contributor

@jacbn jacbn commented Jan 13, 2025

All dev dependencies so not of great concern. A new vulnerability in cross-spawn is a dependency of jest which hasn't seen an update in a year.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.53%. Comparing base (54d5865) to head (5131a09).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1256   +/-   ##
=======================================
  Coverage   36.53%   36.53%           
=======================================
  Files         455      456    +1     
  Lines       19834    19830    -4     
  Branches     6520     6514    -6     
=======================================
- Hits         7246     7245    -1     
  Misses      11933    11933           
+ Partials      655      652    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacbn
Copy link
Contributor Author

jacbn commented Jan 16, 2025

Updating cypress seemed to add new focus boxes around elements that remain in the image, which was causing every image to fail. This isn't strictly bad, so long as it's consistent going forwards -- but the update also seemed to break my local cypress instance such that I wasn't able to start the tests (notably did not break the git actions instance). I'll look into this more at some point, but no need to block the rest of the updates on this.

@sjd210
Copy link
Contributor

sjd210 commented Jan 17, 2025

We've looked into the Cypress update a bit more now. (some testing here) To document that here, there seem to be issues with Mac's virtualisation of the Docker containers that Cypress uses. The update isn't pressing, so we can just hold off until this is fixed or we find a workaround.

As for the focus boxes, they can be removed using .blur() but I agree that as long as the behaviour remains consistent we can just keep them.

@sjd210 sjd210 merged commit 0f16467 into master Jan 17, 2025
4 checks passed
@sjd210 sjd210 deleted the improvement/dependency-update-jan-2025 branch January 17, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants