Deprecate Gameboard Filter #1254
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the filter is gone, there is no need to allow the "filter=true" URL parameter to work any more. We may want to re-use the code from extractFilterQueryString if we ever decide to add links from gameboards to the new question finder, but I have removed it for now since it was unused and doing so allows removing the library too.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1254 +/- ##
==========================================
+ Coverage 36.52% 36.55% +0.02%
==========================================
Files 455 455
Lines 19835 19818 -17
Branches 5849 6496 +647
==========================================
- Hits 7245 7244 -1
+ Misses 12552 12536 -16
Partials 38 38 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace or remove references to gameboard filter, and restricts the gameboard filter to logged in users.
This is softer than the blanket removal we promised for Jan 2025.
Since the filter is gone, there is no need to allow the "filter=true" URL parameter to work any more.
We may want to re-use the code from extractFilterQueryString if we ever decide to add links from gameboards to the new question finder, but I have removed it for now since it was unused and doing so allows removing the library too.