Pass editorMode into text entry's Inequality reference on the equality demo page #1249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is that text entry sometimes doesn't work on switching modes on the demo page. To recreate:
This is broken (only for the demo page) due to the
editorMode
for inequality text entry (hiddenEditorRef
) only being set when the main inequalityeditorMode
changes, but the page reload forcing text entry to be generated again. This regeneratedhiddenEditorRef
therefore doesn’t haveeditorMode
set, so it is set to the default of “logic”.The solution is simply to pass the main
editorMode
intohiddenEditorRef
’seditorMode
when it is generated.