Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User context improvements #1242

Merged
merged 7 commits into from
Dec 10, 2024
Merged

User context improvements #1242

merged 7 commits into from
Dec 10, 2024

Conversation

mwtrew
Copy link
Contributor

@mwtrew mwtrew commented Dec 3, 2024

Various updates to the context picker and viewing contexts:

  • Remove now-inapplicable "unusual context" logic - always show the tooltip with an explanation for the current viewing context.
  • Fix problems with "no content on this page" message not showing on Topic pages. This now relies on the audience field in the topic summary content object being correct, as with Concept pages.
  • Add a reset button to the context picker, which clears the transient context if set.

Best reviewed with whitespace changes hidden.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 26.86567% with 49 lines in your changes missing coverage. Please review.

Project coverage is 36.64%. Comparing base (a4f1a00) to head (9348394).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
...p/components/elements/inputs/UserContextPicker.tsx 4.44% 42 Missing and 1 partial ⚠️
...nents/navigation/IntendedAudienceWarningBanner.tsx 33.33% 2 Missing ⚠️
src/app/state/slices/internalAppState.ts 0.00% 2 Missing ⚠️
src/app/components/pages/Topic.tsx 0.00% 1 Missing ⚠️
src/app/services/userViewingContext.ts 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1242      +/-   ##
==========================================
+ Coverage   36.62%   36.64%   +0.02%     
==========================================
  Files         451      451              
  Lines       19763    19763              
  Branches     6478     6475       -3     
==========================================
+ Hits         7238     7243       +5     
+ Misses      11880    11875       -5     
  Partials      645      645              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwtrew mwtrew marked this pull request as ready for review December 5, 2024 11:03
This is the default context behind the scenes, so it makes sense to be
able to reflect that in the context picker.
@mwtrew mwtrew merged commit 9ac046b into master Dec 10, 2024
4 checks passed
@mwtrew mwtrew deleted the user-context-improvements branch December 10, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants