Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports detected by ESLint #1240

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

jsharkey13
Copy link
Member

No description provided.

@jsharkey13 jsharkey13 requested a review from jacbn November 29, 2024 12:35
Copy link
Member Author

@jsharkey13 jsharkey13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve my own PR, but I have manually checked all 34 files now. There are some minor tailing-whitespaces changes since my IDE also trims that on saving.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 74.60317% with 16 lines in your changes missing coverage. Please review.

Project coverage is 36.61%. Comparing base (88d0cd7) to head (2c822ce).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../components/elements/panels/TeacherConnections.tsx 60.00% 3 Missing and 1 partial ⚠️
...pp/components/content/IsaacLLMFreeTextQuestion.tsx 0.00% 3 Missing ⚠️
...p/components/elements/inputs/UserContextPicker.tsx 50.00% 2 Missing ⚠️
src/app/components/pages/Groups.tsx 50.00% 2 Missing ⚠️
...nents/elements/LLMFreeTextQuestionFeedbackView.tsx 85.71% 1 Missing ⚠️
src/app/components/pages/AssignmentProgress.tsx 66.66% 1 Missing ⚠️
...rc/app/components/pages/RegistrationSetDetails.tsx 80.00% 1 Missing ⚠️
src/app/state/middleware/notificationManager.ts 0.00% 1 Missing ⚠️
src/test/pages/Homepage.cy.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1240   +/-   ##
=======================================
  Coverage   36.61%   36.61%           
=======================================
  Files         451      451           
  Lines       19768    19768           
  Branches     6496     6481   -15     
=======================================
  Hits         7239     7239           
  Misses      11884    11884           
  Partials      645      645           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacbn jacbn merged commit 82b9ca9 into master Nov 29, 2024
4 checks passed
@jacbn jacbn deleted the improvement/optimise-imports-nov24 branch November 29, 2024 14:03
@jsharkey13 jsharkey13 restored the improvement/optimise-imports-nov24 branch December 3, 2024 17:18
@jsharkey13 jsharkey13 deleted the improvement/optimise-imports-nov24 branch December 3, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants