Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Chemistry elements mismatch feedback #659

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

sjd210
Copy link
Contributor

@sjd210 sjd210 commented Nov 27, 2024

Temporarily replaces "Check that you have all the correct atoms present and in the right place!" with blank feedback, as it was sometimes displaying at incorrect times for questions with multiple correct answer configurations in the markscheme.


From a quick look, the problem actually causing this should be fixed by disabling list comparison permutations when allowPermutations = false in the Checker (which should be fairly easy), and reconfiguring the answer match prioritisation code in the API (which is probably not so easy) - certainly probably enough work to be saved for next release.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.42%. Comparing base (d772ec7) to head (2795acd).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #659   +/-   ##
=======================================
  Coverage   34.42%   34.42%           
=======================================
  Files         521      521           
  Lines       23434    23433    -1     
  Branches     2873     2873           
=======================================
  Hits         8066     8066           
+ Misses      14556    14555    -1     
  Partials      812      812           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsharkey13 jsharkey13 merged commit e940804 into master Nov 27, 2024
3 checks passed
@jsharkey13 jsharkey13 deleted the hotfix/temp-remove-misleading-feedback branch November 27, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants