FixesVERSION file not found when launching Isaac Sim
#340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
changed the title
VERSION file not found when launching Isaac Sim
Mayankm96
reviewed
Apr 3, 2024
Mayankm96
reviewed
Apr 3, 2024
Mayankm96
reviewed
Apr 3, 2024
Signed-off-by: Mayank Mittal <[email protected]>
Mayankm96
approved these changes
Apr 4, 2024
Mayankm96
pushed a commit
that referenced
this pull request
Apr 4, 2024
The AppLauncher has a bug where it fails to fact the `app.folder` is
pointing to a directory higher than it should be. This leads to a file
not being found in the `_get_version` call from `omni.isaac.version`
module.
Updated app.folder to point to `"${exe-path}/"` instead of
`"${exe-path}/../"` in the following files:
- orbit/source/apps/orbit.python.headless.kit
- orbit/source/apps/orbit.python.headless.multicam.kit
- orbit/source/apps/orbit.python.kit
Fixes #339
- Bug fix (non-breaking change which fixes an issue)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
ADebor
pushed a commit
to ADebor/IsaacLab
that referenced
this pull request
Apr 8, 2024
# Description This MR fixes the code highlighting in the troubleshooting docs. It was referring to Isaac Sim stuff which we don't need to do anymore. ## Type of change - Bug fix (non-breaking change which fixes an issue) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
# Description This MR fixes the code highlighting in the troubleshooting docs. It was referring to Isaac Sim stuff which we don't need to do anymore. ## Type of change - Bug fix (non-breaking change which fixes an issue) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
The AppLauncher has a bug where it fails to fact the `app.folder` is
pointing to a directory higher than it should be. This leads to a file
not being found in the `_get_version` call from `omni.isaac.version`
module.
Updated app.folder to point to `"${exe-path}/"` instead of
`"${exe-path}/../"` in the following files:
- orbit/source/apps/orbit.python.headless.kit
- orbit/source/apps/orbit.python.headless.multicam.kit
- orbit/source/apps/orbit.python.kit
Fixes isaac-sim#339
- Bug fix (non-breaking change which fixes an issue)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The AppLauncher has a bug where it fails to fact the
app.folderis pointing to a directory higher than it should be. This leads to a file not being found in the_get_versioncall fromomni.isaac.versionmodule.Updated app.folder to point to
"${exe-path}/"instead of"${exe-path}/../"in the following files:Fixes #339
Type of change
Checklist
pre-commitchecks with./orbit.sh --format./orbit.sh --testand they passconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there