Updates simulation flags for performance improvements #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
added a commit
that referenced
this pull request
Jul 24, 2023
# Description Adds a directory `docker` in the root of the repo, containing a `Dockerfile`, `dockerfile-compose.yaml`, `.env`, and utility script `container.sh` that wraps docker-compose CLI commands. The instructions in the documentation specify the installation steps and how to get the Isaac Sim docker image for completeness. To run a container, the user needs to create NGC credentials via the NVIDIA Developers program. After that they can run the script to launch the container: ```bash ./docker/container.sh start ./docker/container.sh enter ``` Also added an argument `-o` or `--docker` to the `orbit.sh` that calls the above script. The above then becomes: ```bash ./orbit.sh -o start ./orbit.sh -o enter ``` Fixes #23 ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [X] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [X] I have made corresponding changes to the documentation - [X] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file --------- Co-authored-by: Mayank Mittal <[email protected]>
Mayankm96
pushed a commit
that referenced
this pull request
Nov 16, 2023
# Description Fixes action indexing for multiple actions. Currently all successive actions mimic the first one due to an indexing error. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Mayankm96
added a commit
that referenced
this pull request
Dec 22, 2023
# Description Adds a directory `docker` in the root of the repo, containing a `Dockerfile`, `dockerfile-compose.yaml`, `.env`, and utility script `container.sh` that wraps docker-compose CLI commands. The instructions in the documentation specify the installation steps and how to get the Isaac Sim docker image for completeness. To run a container, the user needs to create NGC credentials via the NVIDIA Developers program. After that they can run the script to launch the container: ```bash ./docker/container.sh start ./docker/container.sh enter ``` Also added an argument `-o` or `--docker` to the `orbit.sh` that calls the above script. The above then becomes: ```bash ./orbit.sh -o start ./orbit.sh -o enter ``` Fixes #23 ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [X] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [X] I have made corresponding changes to the documentation - [X] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file --------- Co-authored-by: Mayank Mittal <[email protected]>
Mayankm96
pushed a commit
that referenced
this pull request
Dec 22, 2023
# Description Fixes action indexing for multiple actions. Currently all successive actions mimic the first one due to an indexing error. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
# Description Fixes action indexing for multiple actions. Currently all successive actions mimic the first one due to an indexing error. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes some improvements to the
IsaacEnvclass for reducing loading time and improving performance.Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks withpre-commit run --all-files(see here instructions to set it up)config/extension.tomlfile