Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project name option for docker compose #1414

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ZiwenZhuang
Copy link

@ZiwenZhuang ZiwenZhuang commented Nov 13, 2024

Description

Adding project options for docker-compose, so that different people can create their own docker images/containers on the same shared cluster node. (as proposed in proposal #1363)

Type of change

  • New feature (non-breaking change which adds functionality)

Changes preview

  • Before
    (base) ubuntu@desktop:~/isaaclab$ python docker/container.py start
  • After
    (base) ubuntu@desktop:~/isaaclab$ python docker/container.py start --project isaaclab-myname

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant