Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes tensordict dependencies #1413

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removes tensordict dependencies #1413

wants to merge 2 commits into from
+0 −4

Conversation

kellyguo11
Copy link
Contributor

Description

Removes tensordict as a dependency in the installation and extensions for isaac lab since we no longer use it in the codebase.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmith-bdai jsmith-bdai Awaiting requested review from jsmith-bdai jsmith-bdai is a code owner

@Dhoeller19 Dhoeller19 Awaiting requested review from Dhoeller19 Dhoeller19 is a code owner

@Mayankm96 Mayankm96 Awaiting requested review from Mayankm96 Mayankm96 is a code owner

@hhansen-bdai hhansen-bdai Awaiting requested review from hhansen-bdai hhansen-bdai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kellyguo11