-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
container name "orbit" is already in use by "services.orbit-ros2": invalid compose project #325
Comments
This indeed works for me. Thank you very much for your prompt reply and this open-sourced project! Expect your work to be more and more influential! |
Mayankm96
pushed a commit
that referenced
this issue
Mar 28, 2024
# Description As of [docker compose 2.24.7](https://docs.docker.com/compose/release-notes/#2247), using the same name between containers is disallowed even if the profiles that launch them are mutually exclusive. This PR alters `docker-compose.yaml` such that containers will now be appended with their image extension (orbit-base, orbit-ros2). I've also added `resolve_image_extension` to the logic in `./container.sh` in order to handle the image_extension arguments. Fixes Public[ #325](#325) ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./orbit.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: Hunter Hansen <[email protected]> Co-authored-by: James Smith <[email protected]>
ADebor
pushed a commit
to ADebor/IsaacLab
that referenced
this issue
Apr 8, 2024
# Description This MR reviews the how-tos documentation and ensures they are all somewhat consistent. ## Type of change - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
I think this issue is fixed now. Please re-open if the problem reappears :) |
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this issue
Aug 8, 2024
# Description This MR reviews the how-tos documentation and ensures they are all somewhat consistent. ## Type of change - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this issue
Aug 8, 2024
# Description As of [docker compose 2.24.7](https://docs.docker.com/compose/release-notes/#2247), using the same name between containers is disallowed even if the profiles that launch them are mutually exclusive. This PR alters `docker-compose.yaml` such that containers will now be appended with their image extension (orbit-base, orbit-ros2). I've also added `resolve_image_extension` to the logic in `./container.sh` in order to handle the image_extension arguments. Fixes Public[ isaac-sim#325](isaac-sim#325) ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./orbit.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: Hunter Hansen <[email protected]> Co-authored-by: James Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After I install docker and download the code of orbit, I run the following code "./docker/container.sh start", it reports
"[INFO] Building the docker image and starting the container in the background...
WARN[0000] /home/a123/orbit/docker/docker-compose.yaml:
version
is obsolete"services.orbit-base": container name "orbit" is already in use by "services.orbit-ros2": invalid compose project
"
The text was updated successfully, but these errors were encountered: