Skip to content

Commit

Permalink
Fix broken bash version evaluation in Dockerfile (#211)
Browse files Browse the repository at this point in the history
# Description

Tiny PR to fix bash evaluation of ISAACSIM_VERSION in Dockerfile.
Before, it would fail and streaming from Isaac2022.2.1 would fail.

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
  • Loading branch information
hhansen-bdai authored Oct 26, 2023
1 parent 42671ec commit 81fa26d
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,17 @@
ARG ISAACSIM_VERSION
FROM nvcr.io/nvidia/isaac-sim:${ISAACSIM_VERSION}

# Set default RUN shell to bash
SHELL ["/bin/bash", "-c"]

# Adds labels to the Dockerfile
LABEL version="1.0"
LABEL description="Dockerfile for building and running the Orbit framework inside Isaac Sim container image."

# Arguments
# Path to Isaac Sim root folder
ARG ISAACSIM_PATH
ARG ISAACSIM_VERSION

# Set environment variables
ENV LANG=C.UTF-8
Expand Down

0 comments on commit 81fa26d

Please sign in to comment.