Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite gravity _if_ specified in yaml config file #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sheim
Copy link

@sheim sheim commented Nov 4, 2021

Currently, whatever the user writes into the config file for gravity is overwritten in vec_task.py, which is both confusing and not useful. Now checks if the cfg specifies gravity, and only writes default values if it doesn't.

@kellyguo11
Copy link
Collaborator

Hi there, it appears that some of our tasks are making a call to set_sim_params_up_axis(), which is overwriting the gravity values that are specified in the config files. We are thinking of removing the call to set_sim_params_up_axis() from those tasks to avoid the confusion. With this change, we would be reading both up_axis and gravity values directly from the config files. Would that work for your use case?

@sheim
Copy link
Author

sheim commented Nov 11, 2021

I suppose that would, but I've also switched to using isaacGym3 together with legged_gym anyway, so feel free to do what works best for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants