Merge pull request #2816 from irontec/PROVIDER-967-call-csv-scheduler…

…s-email-field-should-be-not-null-default-empty-value Default empty email in CallCsvScheduler
irontec · Nov 27, 2024 · 7ec992a · 7ec992a
2 parents e50efe5 + 8edadd8
commit 7ec992a
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 2 deletions.
diff --git a/library/Ivoz/Provider/Domain/Model/CallCsvScheduler/CallCsvSchedulerAbstract.php b/library/Ivoz/Provider/Domain/Model/CallCsvScheduler/CallCsvSchedulerAbstract.php
@@ -66,7 +66,7 @@ abstract class CallCsvSchedulerAbstract
     /**
      * @var string
      */
-    protected $email;
+    protected $email = '';
 
     /**
      * @var ?\DateTime

diff --git a/library/Ivoz/Provider/Domain/Model/CallCsvScheduler/CallCsvSchedulerDtoAbstract.php b/library/Ivoz/Provider/Domain/Model/CallCsvScheduler/CallCsvSchedulerDtoAbstract.php
@@ -47,7 +47,7 @@ abstract class CallCsvSchedulerDtoAbstract implements DataTransferObjectInterfac
     /**
      * @var string|null
      */
-    private $email = null;
+    private $email = '';
 
     /**
      * @var \DateTimeInterface|string|null

diff --git a/...astructure/Persistence/Doctrine/Mapping/CallCsvScheduler.CallCsvSchedulerAbstract.orm.xml b/...astructure/Persistence/Doctrine/Mapping/CallCsvScheduler.CallCsvSchedulerAbstract.orm.xml
@@ -31,6 +31,7 @@
     <field name="email" type="string" column="email" length="140" nullable="false">
       <options>
         <option name="fixed"/>
+        <option name="default"/>
       </options>
     </field>
     <field name="lastExecution" type="datetime" column="lastExecution" nullable="true"/>

diff --git a/schema/DoctrineMigrations/Version20241114091020.php b/schema/DoctrineMigrations/Version20241114091020.php
@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Application\Migrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Ivoz\Core\Infrastructure\Persistence\Doctrine\LoggableMigration;
+
+/**
+* Auto-generated Migration: Please modify to your needs!
+*/
+final class Version20241114091020 extends LoggableMigration
+{
+    public function getDescription(): string
+    {
+        return 'Added default empty string to email in CallCsvSchedulers';
+    }
+
+    public function up(Schema $schema): void
+    {
+    // this up() migration is auto-generated, please modify it to your needs
+        $this->addSql('ALTER TABLE CallCsvSchedulers CHANGE email email VARCHAR(140) DEFAULT \'\' NOT NULL');
+    }
+
+    public function down(Schema $schema): void
+    {
+        // this down() migration is auto-generated, please modify it to your needs
+        $this->addSql('ALTER TABLE CallCsvSchedulers CHANGE email email VARCHAR(140) NOT NULL');
+    }
+}