New-UDTable creates unnamed endpoint #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a deterministic ID to the UDElement created by New-UDTable. Without this any UDTable will create an endpoint with a new random GUID every time the dashboard is restarted. That causes clients with their browser open during a dashboard restart to suddenly get 404 errors.
adamdriscoll
requested changes
Oct 15, 2019
adamdriscoll
approved these changes
Oct 15, 2019
|
Should this not just be $ID ? |
|
That would create two HTML elements with the same ID, which is invalid and likely to break any JavaScript that depends on document.getElementById |
|
Ah yeah I do see that. Well I would say that the new-udelement -tag "div" should have another Id. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a deterministic ID to the UDElement created by New-UDTable. Without this any UDTable will create an endpoint with a new random GUID every time the dashboard is restarted. That causes clients with their browser open during a dashboard restart to suddenly get 404 errors.
I used "$Id-tbody" as the ID of the endpoint but any value based on $Id should work.