Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

img with float parameter causing layout issues. #1067

Merged
merged 1 commit into from
Aug 30, 2019
Merged

img with float parameter causing layout issues. #1067

merged 1 commit into from
Aug 30, 2019

Conversation

itfranck
Copy link
Contributor

img appear in-between ud-cards because of it.
Other themes do not have their img tag set to float.

img appear in-between ud-cards because of it. 
Other themes do not have their img tag set to float.
@itfranck
Copy link
Contributor Author

@adamdriscoll
Copy link
Member

Nice. Thanks!

@adamdriscoll adamdriscoll merged commit 6bbebe1 into ironmansoftware:master Aug 30, 2019
@psDevUK
Copy link
Contributor

psDevUK commented Aug 30, 2019

Sorry guys worked really well for nesting images in the card. Thought this theme was going to be renamed? Apologies again

@adamdriscoll
Copy link
Member

We did break it out but it looks like that change was still in there. I just realized that the theme is still called psDevUKSpecial. haha https://github.com/ironmansoftware/universal-dashboard/blob/master/src/UniversalDashboard/Themes/DarkRounded.psd1#L2 😆

@psDevUK
Copy link
Contributor

psDevUK commented Aug 30, 2019

Without being lazy but the img float being removed from the DarkRounded theme? Just don’t want anyone else having issues. As mentioned looks sweet in a card. Everyone does things differently.
Just to confirm that the theme Bosen did will replace Azure theme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants