Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page with Endpoint does not work with spaces #734

Closed
leeberg opened this issue Apr 5, 2019 · 3 comments
Closed

Page with Endpoint does not work with spaces #734

leeberg opened this issue Apr 5, 2019 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@leeberg
Copy link
Contributor

leeberg commented Apr 5, 2019

Description

When a page is defined as an endpoint it does work and enables some cool use cases, good stuff! However it seems when my Page is defined as an endpoint instead of Content I cannot have spaces in my page name.

Repro

Consider a Page that is initiated like this:
New-UDPage -Name "Honey Deployment" -Icon empire -Endpoint {

This results in a page not found:
image

By removing the space in the Name Param:
New-UDPage -Name "HoneyDeployment" -Icon empire -Endpoint {

Works great!

image

This is not an issue when the page is defined with Content:

New-UDPage -Name "Honey Deployment" -Icon empire -Content {

@adamdriscoll adamdriscoll added the bug Something isn't working label Apr 5, 2019
@adamdriscoll
Copy link
Member

I have to say, I love that there is a page not found now...

@leeberg
Copy link
Contributor Author

leeberg commented Apr 5, 2019

I have to say, I love that there is a page not found now...

It's a Feature!

adamdriscoll added a commit that referenced this issue Jul 30, 2019
@adamdriscoll
Copy link
Member

This looks fixed in the latest. Added a test in the latest PR.

@adamdriscoll adamdriscoll added this to the 2.5.3 milestone Jul 30, 2019
adamdriscoll added a commit that referenced this issue Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants