Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs in Modal Display issue #1221

Closed
GoGorillaUK opened this issue Oct 3, 2019 · 2 comments
Closed

Tabs in Modal Display issue #1221

GoGorillaUK opened this issue Oct 3, 2019 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@GoGorillaUK
Copy link
Contributor

Describe the Issue

When Tabs are used inside a modal, a scrollbar is displayed on load.
Once any tab is clicked it behaves as expected.

To Reproduce

Steps to reproduce the behavior: (Example)

  1. Start Dashboard
  2. Click on the Hamburger
  3. Press ALT-F4
  4. Browser Closes...

Expected behavior

No scrollbar displayed on load

Screenshots

If applicable, add screenshots to help explain your problem.
image

Script Sample

New-UDButton -Text 'More Tabs' -Icon baseball_ball -onclick{
    Show-UDModal -Content{
        
            New-UDTabContainer  -Tabs {
                New-UDTab -Text 'Tab1.1' -Content{
                    New-UDParagraph -Text 'This is Tab1.1'
                }
        
                New-UDTab -Text 'Tab2.1' -Content{
                    New-UDParagraph -Text 'This is Tab2.1'
                }
        
                New-UDTab -Text 'Tab3.1' -Content{
                    New-UDParagraph -Text 'This is Tab3.1'
                }
        
        } 
    } 
}

Version Information

  • Operating System: Windows 10
  • PowerShell Version: 5
  • Universal Dashboard Version: 2.6.0
  • UD Hosting Method: Powershell
@GoGorillaUK GoGorillaUK added the bug Something isn't working label Oct 3, 2019
@dtnyc9005
Copy link

beat me to it ;) confirmed, this is also happening in one of my modals.

@adamdriscoll
Copy link
Member

mattselle added a commit to mattselle/universal-dashboard that referenced this issue Dec 11, 2019
Models have issues trying to figure out how wide they are so we need to tell materialize to update the tabIndicator so we dont get a scroll bar.
ironmansoftware#1221
adamdriscoll pushed a commit that referenced this issue Dec 11, 2019
* Fix label overlap issue when value is provided

#1330

* Placeholder should be active label and not overlap

#921

* Revert "Placeholder should be active label and not overlap"

This reverts commit 938fd37.

* UpdateTabIndicator so we dont get a scroll

Models have issues trying to figure out how wide they are so we need to tell materialize to update the tabIndicator so we dont get a scroll bar.
#1221
@adamdriscoll adamdriscoll added this to the 2.8.0 milestone Dec 11, 2019
adamdriscoll added a commit that referenced this issue Jan 7, 2020
* Fix label overlap issue when value is provided

#1330

* Placeholder should be active label and not overlap

#921

* Revert "Placeholder should be active label and not overlap"

This reverts commit 938fd37.

* UpdateTabIndicator so we dont get a scroll

Models have issues trying to figure out how wide they are so we need to tell materialize to update the tabIndicator so we dont get a scroll bar.
#1221

* Add test for disabled textbox

#1380

* Disabled InputField

Adding Disabled to new-inputfield
#1380

* Remove false

* Update NewInputFieldCommand.cs

Co-authored-by: Adam Driscoll <[email protected]>
adamdriscoll added a commit that referenced this issue Jan 7, 2020
* Fix label overlap issue when value is provided

#1330

* Placeholder should be active label and not overlap

#921

* Revert "Placeholder should be active label and not overlap"

This reverts commit 938fd37.

* UpdateTabIndicator so we dont get a scroll

Models have issues trying to figure out how wide they are so we need to tell materialize to update the tabIndicator so we dont get a scroll bar.
#1221

* Add test for disabled textbox

#1380

* Disabled InputField

Adding Disabled to new-inputfield
#1380

* Remove false

* Update NewInputFieldCommand.cs

* Component to Content

#1421

Co-authored-by: Adam Driscoll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants