Move to new io/path/fs/net API #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Building with latest rustc (2015-03-06) is blocked by rust-lang/rust#22432 |
| if self.exists() { | ||
| fs::rmdir_recursive(self) | ||
| fs::remove_dir_all(self) |
There was a problem hiding this comment.
Should there be locking for this operation as well? Can concurrent mkdir_recursive and this cause issues?
There was a problem hiding this comment.
While it doesn't matter for the tests from iron/static (they only remove their very own directy) I think we should look rm as well. Just in case.
There was a problem hiding this comment.
Sounds like a plan. Make the change and I'll give a final pass (everything else LGTM though).
Update tests Remove fs feature attribute Add path_ext feature attribute Add mutex for mkdir op Calling fs::create_dir_all concurrently in tests can lead to race conditions Synchronize rm operations as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.