Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation for dkg create #729

Merged
merged 2 commits into from
Oct 10, 2024
Merged

documentation for dkg create #729

merged 2 commits into from
Oct 10, 2024

Conversation

patnir
Copy link
Contributor

@patnir patnir commented Oct 10, 2024

What changed?

  • Adds wallet:multisig:dkg:create documentation

Reminder: If content (docs, blogs, pages) is moved or renamed, please ensure there are no broken links.

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 6:15pm

Comment on lines 42 to 43
Round1 on Ledger... Ledger Locked
? Ledger Locked. Unlock and press enter to retry: Retry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep the retries in the example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it

2. [`wallet:multisig:dkg:round2`](/use/get-started/cli-cmd-wallet-multisig-dkg-round2)
3. [`wallet:multisig:dkg:round3`](/use/get-started/cli-cmd-wallet-multisig-dkg-round3)

This command has built in retry logic to handle failures and will not create the account until the DKG process is successfully run.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This command has built in retry logic to handle failures and will not create the account until the DKG process is successfully run.
This command has built-in retry logic to handle failures and will not create the account until the DKG process is successfully run.


This command has built in retry logic to handle failures and will not create the account until the DKG process is successfully run.

Further more, a primary benefit of this command is when using the `--ledger` flag, the command will retrieve the identities from the Ledger device and handle retries/ failures for you.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Further more, a primary benefit of this command is when using the `--ledger` flag, the command will retrieve the identities from the Ledger device and handle retries/ failures for you.
Furthermore, a primary benefit of this command is when using the `--ledger` flag, the command will retrieve the identities from the Ledger device and handle retries/failures for you.

@patnir patnir merged commit ebc03c0 into master Oct 10, 2024
2 checks passed
@patnir patnir deleted the rahul/dkg-create branch October 10, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants