Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Fix fuxi-3000 consensus failure #109

Merged
merged 2 commits into from
Sep 22, 2018
Merged

R4R: Fix fuxi-3000 consensus failure #109

merged 2 commits into from
Sep 22, 2018

Conversation

abelliumnt
Copy link

According to my analysis, I think the main reasons of the consensus failure of fuxi-3000 are as follows:

  • Due the there is not enough voting power at the start of the network, the network has been stucked for a long time. So the double sign evidence has been broadcasted to almost all nodes. Once voting power is enough, then the evidenve will be included in the first block.
  • Then each node attempts to apply this block. In beginBlock, the evidence will invoke slashing. However, in this situation, infractionHeight is 1 and ctx.BlockHeight() is 0. Then panic error happened.

Besides, when a validator is new added and it launchs double sign attack in the first block after it become a real validator. Then the double sign evidence happen to be included by the block proposal, then in the beginBlock, we will try to slash a validator which has no sign info. However, the sign info is required for figuring out the jail period. This panic error is just for checking the existence of validator sign info.
But this situation is possible and reasonable, we can't just panic, instead we should check the sign info of a validator before slashing it.

@wukongcheng wukongcheng merged commit 1ff2982 into irisnet:irisnet/hotfix-v0.23.0-iris4 Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants