Skip to content

Commit

Permalink
rpc: remove debug logging
Browse files Browse the repository at this point in the history
This was added recently, in cockroachdb#94778, and contributes to log spam of the
following sort:

I230404 15:00:33.826337 2400 rpc/context.go:2249  [T1,n1,rnode=2,raddr=127.0.0.1:55941,class=default,rpc] 268  connection heartbeat loop ended with err: <nil>
I230404 15:00:33.826338 3986 rpc/context.go:2249  [T1,n2,rnode=3,raddr=127.0.0.1:55955,class=system,rpc] 269  connection heartbeat loop ended with err: <nil>
I230404 15:00:33.826367 3455 rpc/context.go:2249  [T1,n2,rnode=3,raddr=127.0.0.1:55955,class=default,rpc] 270  connection heartbeat loop ended with err: <nil>
I230404 15:00:33.826394 3354 rpc/context.go:2249  [T1,n2,rnode=2,raddr=127.0.0.1:55941,class=default,rpc] 271  connection heartbeat loop ended with err: <nil>

Release note: None
  • Loading branch information
irfansharif committed Apr 7, 2023
1 parent 659b90b commit f03554c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/rpc/context.go
Original file line number Diff line number Diff line change
Expand Up @@ -2298,8 +2298,7 @@ func (rpcCtx *Context) grpcDialNodeInternal(
// Run the heartbeat; this will block until the connection breaks for
// whatever reason. We don't actually have to do anything with the error,
// so we ignore it.
err := rpcCtx.runHeartbeat(ctx, conn, target)
log.Infof(ctx, "connection heartbeat loop ended with err: %v", err)
_ = rpcCtx.runHeartbeat(ctx, conn, target)
maybeFatal(ctx, rpcCtx.m.Remove(k, conn))

// Context gets canceled on server shutdown, and if that's likely why
Expand Down

0 comments on commit f03554c

Please sign in to comment.