Skip to content

Commit

Permalink
kvflowcontrol: enable by default
Browse files Browse the repository at this point in the history
Enable kvadmission.flow_control.enabled by default. We didn't observe
noticeable performance regressions while it was disabled (single weekly
run, three nightly runs). There was some minimal fallout that was since
fixed (cockroachdb#104699). We expect performance regressions now that this commit
enables it by default, and expect more fallout. We'll handle these as
part of cockroachdb#104154.

Release note: None
  • Loading branch information
irfansharif committed Jun 12, 2023
1 parent 5d630ae commit d75e8bc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/kv/kvserver/kvflowcontrol/kvflowcontrol.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var Enabled = settings.RegisterBoolSetting(
settings.SystemOnly,
"kvadmission.flow_control.enabled",
"determines whether we use flow control for replication traffic in KV",
false,
true,
)

// Mode determines the 'mode' of flow control we use for replication traffic in
Expand Down

0 comments on commit d75e8bc

Please sign in to comment.