Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This is quite the workhorse, and does a lot and has to be compatible with a lot of existing CRDB versions. It's grown organically as a result and I'm finding it a bit difficult to maintain, breaking it down a bit makes it clearer what the structure of it all is and would've perhaps prevented me introducing bugs like cockroachdb#51497. Do scrutinize the PR closely, we use `roachprod start` everywhere. It's mostly mindless code movement but I did sneak in the fix for cockroachdb#51497 where I'd broken node ID assignments for when `roachprod start` is called with the `--sequential` flag (true by default). I did so by explicitly initializing the first node, and then having the remaining nodes join on to it. Release note: None
- Loading branch information