Skip to content

Commit

Permalink
Fix a crash bug in async Java compilation
Browse files Browse the repository at this point in the history
Also add an integration test to avoid this happening again.

Progress on bazelbuild#6394.

PiperOrigin-RevId: 245731141
  • Loading branch information
ulfjack authored and copybara-github committed Apr 29, 2019
1 parent 3ab4dbc commit e4f3e84
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -543,9 +543,10 @@ public ActionContinuationOrResult execute()
throw new ActionExecutionException(e, JavaCompileAction.this, /*catastrophe=*/ false);
}
return new JavaFallbackActionContinuation(
actionExecutionContext,
results,
SpawnContinuation.ofBeginExecution(spawn, actionExecutionContext));
actionExecutionContext,
results,
SpawnContinuation.ofBeginExecution(spawn, actionExecutionContext))
.execute();
} catch (IOException e) {
throw printIOExceptionAndConvertToActionExecutionException(actionExecutionContext, e);
} catch (ExecException e) {
Expand Down

0 comments on commit e4f3e84

Please sign in to comment.