Replace all globs in IREE core with enforce_glob
#5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMNGeoffrey
changed the title
enforce_glob
GMNGeoffrey
commented
Mar 11, 2021
| @@ -43,6 +43,7 @@ def _deep_copy_recursion_depth_1(x): | |||
|
|
|||
| def deep_copy(x): | |||
| """Returns a copy of the argument, making a deep copy if it is a container. | |||
|
|
|||
There was a problem hiding this comment.
Uh... this has nothing to do with the change. I apparently just fixed a thing buildifier was complaining about. I can revert
ScottTodd
approved these changes
Mar 11, 2021
GMNGeoffrey
added a commit
to GMNGeoffrey/iree
that referenced
this pull request
Mar 11, 2021
These come from midair collision between iree-org#5063 and iree-org#4881
GMNGeoffrey
added a commit
that referenced
this pull request
Mar 11, 2021
GMNGeoffrey
added a commit
to GMNGeoffrey/iree
that referenced
this pull request
Mar 11, 2021
Midair collision between iree-org#4999 and iree-org#5063
GMNGeoffrey
added a commit
that referenced
this pull request
Mar 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids any globs of source files in CMake (which are
discouraged)
and any globs being evaluated in bazel_to_cmake (which would make it
depend on files other than the BUILD file). It still allows the safety
check that you actually included all the files you meant to (which is
particularly useful with tests, where a failure to do so is test
skipped forever instead of an immediate build failure). The cost is
having to explicitly list a new source file when you add it, which
seems not so bad.
I didn't remove bazel_to_cmake support for glob yet, so I can clean up
any stragglers after this lands.
Fixes #1083