[LLVMGPU][ROCm] Plumb through i8, i8 -> i32 MFMA intrinsics #17764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhar
requested review from
MaheshRavishankar,
qedawkins,
Groverkss and
antiagainst
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
antiagainst
approved these changes
Jun 28, 2024
antiagainst
reviewed
Jun 28, 2024
This was referenced Jun 29, 2024
Open
LLITCHEV
pushed a commit
to LLITCHEV/iree
that referenced
this pull request
Jul 30, 2024
…#17764) Add tests to make sure these are generated in the vector distribution pipeline. Add e2e correctness tests. I also tested this manually on random inputs against golden outputs from numpy. This contains one cherry-pick for llvm-project. --------- Co-authored-by: Stanley Winata <[email protected]> Co-authored-by: Lei Zhang <[email protected]> Signed-off-by: Lubo Litchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to make sure these are generated in the vector distribution pipeline. Add e2e correctness tests.
I also tested this manually on random inputs against golden outputs from numpy.
This contains one cherry-pick for llvm-project.