-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compile][rocm]: error: 'llvm.fptrunc' op result #0 must be floating point LLVM type or LLVM dialect-compatible vector of floating point LLVM type, but got 'i8' #18367
Comments
@andfau-amd could you please take a look |
Okay, I'll try to find time to look at it today. FWIW I doubt this has any relation to my recent fptrunc-related changes, but I'm still happy to look at it. |
Oh I am not saying it's related, but as I mentioned, these are bugs being filed as part of general compiler testing that is being ramped up. |
@pdhirajkumarprasad there's no support for |
@nithinsubbiah this small IR created from big model. We don't have plan to support this? if so then user need to modify it manually? |
If a compiler target (https://github.com/iree-org/iree/tree/main/compiler/plugins/target) can't handle a data type, it should signal that with a clear error message early in the compilation pipeline. |
There might be a long winded path of supporting it, but it isnt easy, and probably not what users wants to begin with. So it would be better to change the input anyway. |
Good point. @nithinsubbiah can you add a check before |
@nithinsubbiah , is the plan to modify the MLIR by running a script for now to work around and keep this issue open for real fix? |
There is no real fix. We cant support the data type cause it is not supported on the hardware. We can error out, but the fix is to fix the front end. |
…18423) Add a check for valid quantized data types for the ROCm backend fixes iree-org#18367 Signed-off-by: nithinsubbiah <[email protected]>
…18423) Add a check for valid quantized data types for the ROCm backend fixes iree-org#18367 Signed-off-by: nithinsubbiah <[email protected]>
What happened?
for the given IR
getting error as
unknown>:0: error: 'llvm.fptrunc' op result #0 must be floating point LLVM type or LLVM dialect-compatible vector of floating point LLVM type, but got 'i8'
:0: note: see current operation: %87 = "llvm.fptrunc"(%86) : (f16) -> i8
Steps to reproduce your issue
command to reproduce:
dump.log
dump.log with flag "--mlir-print-ir-after-all --mlir-print-ir-before-all --mlir-disable-threading --mlir-elide-elementsattrs-if-larger=4"
What component(s) does this issue relate to?
Compiler
Version information
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: