Skip to content

Commit

Permalink
Rewriting/simplifying DynamicLibrary in C.
Browse files Browse the repository at this point in the history
This allowed for a lot of file IO code to go away - there was needless
abstraction here as there was only a single user of a lot of these things
that was already platform-specialized.

Progress on #4369 and #3848.
Fixes #4642.
Unblocks #3845, which can now be added cleanly.

# Conflicts:
#	iree/hal/local/loaders/legacy_library_loader.c
  • Loading branch information
benvanik committed Mar 24, 2021
1 parent 500ec7b commit c5b070e
Show file tree
Hide file tree
Showing 44 changed files with 1,206 additions and 1,227 deletions.
20 changes: 0 additions & 20 deletions iree/base/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -63,26 +63,6 @@ cc_library(
# Internal IREE C++ wrappers and utilities
#===------------------------------------------------------------------------===#

cc_library(
name = "dynamic_library",
srcs = [
"dynamic_library_posix.cc",
"dynamic_library_win32.cc",
],
hdrs = ["dynamic_library.h"],
deps = [
":core_headers",
":logging",
":status",
":tracing",
"//build_tools:default_linkopts",
"//iree/base/internal:file_path",
"@com_google_absl//absl/memory",
"@com_google_absl//absl/strings",
"@com_google_absl//absl/types:span",
],
)

cc_library(
name = "flatcc",
hdrs = ["flatcc.h"],
Expand Down
20 changes: 0 additions & 20 deletions iree/base/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -48,26 +48,6 @@ iree_cc_library(
PUBLIC
)

iree_cc_library(
NAME
dynamic_library
HDRS
"dynamic_library.h"
SRCS
"dynamic_library_posix.cc"
"dynamic_library_win32.cc"
DEPS
::core_headers
::logging
::status
::tracing
absl::memory
absl::span
absl::strings
iree::base::internal::file_path
PUBLIC
)

iree_cc_library(
NAME
flatcc
Expand Down
80 changes: 0 additions & 80 deletions iree/base/dynamic_library.h

This file was deleted.

72 changes: 0 additions & 72 deletions iree/base/dynamic_library_posix.cc

This file was deleted.

160 changes: 0 additions & 160 deletions iree/base/dynamic_library_win32.cc

This file was deleted.

Loading

0 comments on commit c5b070e

Please sign in to comment.