-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial metadata registry #244
Conversation
No need to restrict this. I’m already using smaller ones. |
Yeah it's a bit interesting. Are we just gonna allow people to use any number there? Do regular image/avatar hosting services that allow receiving a resized image usually support any number, only multiples of 2, etc? |
I’ve seen hosts that accept any number (gravatar, IRCCloud) and some that round numbers to the nearest checkpoint (slack I think?) I’m sure others would just ignore unknown numbers. All cases fallback to showing an image at least. |
Sounds good, I'll adjust it. If need be we can suggest requesting again with different sizes down the line or w/e |
Cool. Might be worth mentioning that it’s a standard URI template that can be filled in with widely available libraries https://tools.ietf.org/html/rfc6570 |
values: | ||
- key: avatar | ||
description: Avatar that graphical clients can show alongside the user's name | ||
format: URL with an optional `{size}` substitution denoting the size to load in pixels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it height or width?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original issue stated "square dimension" so both.
Based on ircv3/ircv3-specifications#336
Travis fails on this because the yaml checker's a bit silly and fails with emoji (i wil fix dat). Otherwise, this feels like what we want out of a metadata registry yeah?