Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial metadata registry #244

Merged
merged 7 commits into from
Jul 15, 2019
Merged

Add initial metadata registry #244

merged 7 commits into from
Jul 15, 2019

Conversation

DanielOaks
Copy link
Member

@DanielOaks DanielOaks commented Apr 10, 2019

Based on ircv3/ircv3-specifications#336

Travis fails on this because the yaml checker's a bit silly and fails with emoji (i wil fix dat). Otherwise, this feels like what we want out of a metadata registry yeah?

@jwheare
Copy link
Member

jwheare commented Apr 10, 2019

one of 128, 256, 512, 1024, or 2048

No need to restrict this. I’m already using smaller ones.

@DanielOaks
Copy link
Member Author

Yeah it's a bit interesting. Are we just gonna allow people to use any number there? Do regular image/avatar hosting services that allow receiving a resized image usually support any number, only multiples of 2, etc?

@jwheare
Copy link
Member

jwheare commented Apr 10, 2019

I’ve seen hosts that accept any number (gravatar, IRCCloud) and some that round numbers to the nearest checkpoint (slack I think?) I’m sure others would just ignore unknown numbers. All cases fallback to showing an image at least.

@DanielOaks
Copy link
Member Author

Sounds good, I'll adjust it. If need be we can suggest requesting again with different sizes down the line or w/e

@jwheare
Copy link
Member

jwheare commented Apr 10, 2019

Cool. Might be worth mentioning that it’s a standard URI template that can be filled in with widely available libraries https://tools.ietf.org/html/rfc6570

values:
- key: avatar
description: Avatar that graphical clients can show alongside the user's name
format: URL with an optional `{size}` substitution denoting the size to load in pixels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it height or width?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original issue stated "square dimension" so both.

_data/metadata_registry.yml Show resolved Hide resolved
registry.md Show resolved Hide resolved
_data/metadata_registry.yml Outdated Show resolved Hide resolved
@DanielOaks DanielOaks merged commit 77bdf8e into master Jul 15, 2019
@DanielOaks DanielOaks deleted the metadata-registry branch July 15, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants