Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clients shouldn't send prefix of :<nick> #33

Closed
DanielOaks opened this issue Dec 24, 2016 · 6 comments
Closed

Clients shouldn't send prefix of :<nick> #33

DanielOaks opened this issue Dec 24, 2016 · 6 comments

Comments

@DanielOaks
Copy link
Member

DanielOaks commented Dec 24, 2016

Simply put, clients shouldn't put prefixes on messages in general. esp. not when it's just their nickname. Just wastes space and makes things a bit more fragile. I should recommend avoiding it.

@DanielOaks
Copy link
Member Author

We now tell clients to avoid this thanks to 9023f3a

@nevivurn
Copy link

I think the language could be clearer on this.

Compare the language on RFC 2812

Clients SHOULD NOT use a prefix when sending a message; if they use one, the only valid prefix is the registered nickname associated with the client.

to the current

Clients MAY include a prefix of their nickname on messages they send (after connection registration has been completed). However, I'd avoid doing so [...]

Sending a : prefix is not "OPTIONAL", it should be "NOT RECOMMENDED" (RFC 2119).

@DanielOaks
Copy link
Member Author

True, I'll bring it back to more forceful language here, thanks for pointing it out!

@DanielOaks DanielOaks reopened this Nov 20, 2017
FrozenPigs pushed a commit to FrozenPigs/modern-irc that referenced this issue Dec 9, 2018
@FrozenPigs FrozenPigs mentioned this issue Dec 9, 2018
@progval
Copy link
Member

progval commented Aug 29, 2021

@progval progval closed this as completed Aug 29, 2021
@SadieCat
Copy link
Contributor

SadieCat commented Aug 29, 2021

If they do include one, the only valid source is the current nickname of the client.

This is specifically what the issue is about as it doesn't match how things are implemented in practise. I think most servers just ignore a prefix if sent by a client.

It should probably be revised to say that clients should not send a prefix and servers should ignore it entirely if sent regardless of what it contains.

@progval
Copy link
Member

progval commented Aug 29, 2021

Good point. Done in GH-120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants