Emit UpdateEvent event similar to SDK v4
#998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irazasyed
reviewed
Aug 11, 2022
alies-dev
changed the title
UpdateEvent event similar to SDK v4
alies-dev
commented
Aug 20, 2022
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateEventevent back-ported from SDK v4.Differences with SDKv4 events:
public Bot $bot, in current PR it'spublic Api $telegram;. Reason -- there is noBotclass in SDK v3.\League\Event\AbstractEvent(because we useleague/eventevents system here), in SDK v4 it doesn't extend any classes.Challenges
SDK v3 has a weird feature, I don't know a reason why we have it. This is
$shouldEmitEventparameter:I decided to not touch it, always emit a new event and keep emitting the old one
UpdateWasReceiveddepends on $shouldEmitEvent argument's value. Reason - it provides more consistency with SDK v4.