Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Laravel 8.0 to GitHub Actions #819

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Added Laravel 8.0 to GitHub Actions #819

merged 1 commit into from
Dec 5, 2020

Conversation

roelofr
Copy link
Contributor

@roelofr roelofr commented Dec 5, 2020

I added Laravel 8.0 to the CI, but with an exception on PHP 7.2 (since it's not
supported by Laravel 8.0).

I also used the semver notation (^8.0) instead of the wildcard notation
(8.*) since Laravel has been Semver since 6.0.

@roelofr roelofr marked this pull request as ready for review December 5, 2020 15:14
@roelofr
Copy link
Contributor Author

roelofr commented Dec 5, 2020

GitHub Actions seems to not have .github/ listed as one of the paths to trigger the pipeline, so I ran my own tests here.

@irazasyed irazasyed merged commit ee7d5ed into irazasyed:develop Dec 5, 2020
@roelofr roelofr deleted the feature/test-laravel-8-in-ci branch December 5, 2020 15:31
@irazasyed
Copy link
Owner

Thanks @roelofr 👍

GitHub Actions seems to not have .github/ listed as one of the paths to trigger the pipeline

Yeah, Gotta update that but we've moved to its dedicated home as part of the major changes for the upcoming release of v4.x here. You're welcome to join there and create any PRs :)

@roelofr
Copy link
Contributor Author

roelofr commented Dec 5, 2020

Yeah, I started working on a PR for the same purpose there, but the unit tests all failed 🙊

Is that still very much a WIP?

@irazasyed
Copy link
Owner

Tests are still WIP but the SDK itself is mostly completed and I don't see anymore changes happening for now and because of the major changes, the tests need to be rewritten.

@jonnywilliamson was working on some of the tests but definitely any additional helping hand with regard to the tests would greatly help us with the progress besides the docs that is pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants