Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mostly codesniffer fixes and some formatting #72

Merged
merged 7 commits into from
Dec 1, 2015
Merged

Mostly codesniffer fixes and some formatting #72

merged 7 commits into from
Dec 1, 2015

Conversation

jonnywilliamson
Copy link
Contributor

Removes a few CS warnings and made a couple of areas in the code clearer to understand with more spacing.

}

/**
* Remove a command from the list.
*
* @param $name
*
* @return $this
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be @return Api

@jonnywilliamson
Copy link
Contributor Author

Actually should it not be @return CommandBus ?

That's what the addcommand/addcommands/removecommands all have....

eg:

  /**
     * Add a command to the commands list.
     *
     * @param CommandInterface|string $command Either an object or full path to the command class.
     *
     * @throws TelegramSDKException
     *
     * @return CommandBus
     */
    public function addCommand($command)

I'll add the commit when you confirm

@irazasyed
Copy link
Owner

Yes, That's what it should say! Sorry i didn't actually notice the file name.

@return CommandBus

irazasyed added a commit that referenced this pull request Dec 1, 2015
Codesniffer fixes and some formatting
@irazasyed irazasyed merged commit c50465a into irazasyed:master Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants