Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added FileInputTest #674

Closed
wants to merge 2 commits into from
Closed

Added FileInputTest #674

wants to merge 2 commits into from

Conversation

setnemo
Copy link
Contributor

@setnemo setnemo commented Oct 4, 2019

For issue #5

@welcome
Copy link

welcome bot commented Oct 4, 2019

💖 Thanks for opening this pull request! 💖

@jonnywilliamson
Copy link
Contributor

Wouldn't this fail if I ran the tests offline?

I work 85% without an internet connection when programming. It sucks.

@setnemo
Copy link
Contributor Author

setnemo commented Oct 4, 2019

Wouldn't this fail if I ran the tests offline?

I work 85% without an internet connection when programming. It sucks.

@jonnywilliamson I think I fixed it

@irazasyed
Copy link
Owner

Hey @omentes, Thanks for the PR. Could you please write tests for the develop branch instead and send a PR there. Master will most likely retire in some time. Develop has become the primary as of now (3.0) and I'll be changing the structure a bit later to make things easier and less confusing. Too many changes in both branches have already caused a lot of conflicts unfortunately and we can't merge both. Thanks!

@irazasyed irazasyed closed this Oct 4, 2019
@setnemo setnemo mentioned this pull request Oct 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@setnemo @jonnywilliamson @irazasyed