Add removeCommand() and removeCommands() methods to API. #66
Conversation
| * @expectedException InvalidArgumentException | ||
| * @link https://phpunit.de/manual/3.7/en/appendixes.annotations.html#appendixes.annotations.dataProvider | ||
| */ | ||
| public function it_should_only_allow_a_string_as_the_api_token($type) |
There was a problem hiding this comment.
Method name ApiTest::it_should_only_allow_a_string_as_the_api_token is not in camel caps format
|
So nitpick seems to be doing its job and i was bombarded with email notifications :| |
|
Well I'll update my snippet for tests to put a "public" visibility for each function. As for camel case caps? Mmmm. |
| * @test | ||
| * @expectedException Telegram\Bot\Exceptions\TelegramSDKException | ||
| */ | ||
| public function it_should_throw_exception_if_supplied_command_class_does_not_exist() |
There was a problem hiding this comment.
Method name ApiTest::it_should_throw_exception_if_supplied_command_class_does_not_exist is not in camel caps format
|
Have to ignore camel case caps check, Let me check their docs. |
|
@irazasyed How about adding the nitpick.json config file and bypassing the test directory? Example here: |
|
@jonnywilliamson I just added but ignoring would completely ignore all the checks. Including like the visibility one (like it suggested) and other PSR2 violations. |
Add removeCommand() and removeCommands() methods to API.
Added new tests to verify the new methods.
Have also added other new tests in the new suggested format for naming. I have left the other test names alone just so we can see what both look like.